Remove legacy duckdb_entrypoint macro #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old extension API is superseded by duckdb_entrypoint_c_api which uses DuckDB's modern C extension API with proper version negotiation and error handling.
mlafeldt
force-pushed
the
remove_duckdb_entrypoint
branch
from
ee96b1b to
ea6b2fd
Compare
Member
Author
|
@samansmink I think you worked on the macros last, so it's your honor to tell me if this is ok. 😄 |
samansmink
approved these changes
Dec 18, 2025
Collaborator
samansmink
left a comment
samansmink
left a comment
There was a problem hiding this comment.
looks good to me! the legacy entrypoint macro was never used in our rust extension template so let's rip it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old extension API is superseded by
duckdb_entrypoint_c_api, which uses DuckDB's modern C extension API with proper version negotiation and error handling.