Consolidate loadable extension features #654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having two separate features was confusing:
vtab-loadable- macros onlyloadable-extension- linking changes onlyUsers needed both for working extensions. Using
vtab-loadablealone produced non-functional extensions (DuckDB linked statically into cdylib → two DuckDB instances when loaded → broken).Before:
After:
vtab-loadableis preserved as a deprecated alias pointing toloadable-extension. ExistingCargo.tomlfiles continue to work.What does this mean for https://github.com/duckdb/extension-template-rs?
After the next release, we can change
to
(though the old way will still work)