libduckdb-sys/build.rs: fix link directive when statically linking #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env_prefix() would always return the same static string. Rather than making it a constant, I just remove it. This simplifies the code a bit: fewer format!(), fewer function calls. Additionally, grepping for the env vars is now possible.
It was used as library name and as a dir name. It would always return the same value. There's not much point to it. I could make it a const, using it in vcpkg/pkg-config-related statements, but I don't think there's much of a point to it.
And not libduckdb.a. See https://github.com/duckdb/duckdb/blob/3543aaffe88bd44f1d5a359dfaff13780953c63e/CMakeLists.txt#L465 for a(n unsatisfactory) reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static lib is usually named libduckdb_static.a, not libduckdb.a.
Additionally, I remove the env_prefix & lib_name helpers:
This fixes #651.