Avoid Windows mtime restore in bundled builds#766
Merged
Conversation
The reproducible source archive previously used Unix epoch mtimes. On Windows targets backed by FAT/FAT32, restoring that timestamp can fail because those filesystems cannot represent Unix epoch times. That surfaces as SetFileTime ERROR_INVALID_PARAMETER during tar unpacking. Do not preserve archive mtimes when unpacking bundled sources, and keep generated archive mtimes at 2000-01-01 so the artifact remains deterministic and filesystem-compatible.
mlafeldt
added a commit
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reproducible source archive previously used Unix epoch mtimes. On Windows targets backed by FAT/FAT32, restoring that timestamp can fail because those filesystems cannot represent Unix epoch times.
Fixes #764
Tested with and without the fix in CI: https://github.com/duckdb/duckdb-rs/actions/runs/26278548238