Add basic != pushdown and parens #513
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes some changes from #477 as getting it to be reasonable and generic within duckdb is proving to be difficult rather than just simple sql handling. Trying to break that down into small PRs like this as much as I can, but keeping it up for history.
This adds != filtering, which should be useful on partitioned datasets where this is the partition column (or was at the time of writing), adds parenthesis for some clarity and to prevent any additional issues arising from order of operations as the function is eventually used in more complex contexts.
I checked and support for pushing down not equals predicates was explicitly added to duckdb-delta
Adds support for only parsing one side of an AND expression, I'm not sure how needed it is without the complex parsing (I couldn't find a repro without it), but logically it seems more consistent to always try and filter out as much as possible, rather than rely on subsequent calls from the generate expressions which parses each of them out.