enable postgres inlining and add tests #518
Open
+179
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclowes
commented
Oct 15, 2025
|
|
||
|
|
||
| statement ok | ||
| ATTACH 'ducklake:${DUCKLAKE_CONNECTION} options=''-c lock_timeout=1''' AS ducklake (DATA_PATH '${DATA_PATH}/ducklake_transaction_conflict_files', ENCRYPTED, DATA_INLINING_ROW_LIMIT 10000) |
There was a problem hiding this comment.
I can't figure out how to have the "default" test configuration skip these tests, ie when duckdb is being used as the metadata catalog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a blanket disable, can we enable it with caveats?
I'd be interested in fixing the data type issues but it seems an easy solution isn't available. I wonder if writing parquet files in bytea columns to the postgres database is a reasonable approach as data types won't be a problem and the scan methods could be adapted in a relatively easy manner? Just an idea and wondering if you all have another approach you are planning.