-
Notifications
You must be signed in to change notification settings - Fork 46
Handle macOS cross-compilation for Rust extensions #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, thanks @mlafeldt! |
Does not fix #158 |
We also need to update the Rust template to actually incorporate the fix. See duckdb/extension-template-rs#29 |
And I think we also have to update https://github.com/duckdb/community-extensions/blob/main/extensions/rusty_quack/description.yml#L15 so rusty_quack gets redeployed. |
You are also welcome to send a PR bumping rusty_quack descriptor (and adding yourself as maintainer) after duckdb/extension-template-rs#29 is in. Thanks!! |
@carlopi Did both in duckdb/community-extensions#538 |
Fixes #158
Fixes duckdb/extension-template-rs#28
Testing on my ARM Mac: