Minor fixes #1
Merged
Minor fixes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
have the other fixed in duckdb/duckdb-rs#392, so looks good to me |
|
Cool, then if in the dukdb-rs PR the env variable checked is DUCKDB_EXTENSION_NAME this can also be changed to do so (so they stay consistent). |
|
Yea perhaps it makes sense to use the DUCKDB_EXTENSION_NAME, the crate name should probably be independent of the extension name anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning connected to function name not being snake-case.
Fix package name to be the same as extension name (this I somehow need on Wasm side, and I think it's just cleaner).
I experimented with having the name also inherited in
src/lib.rs, and one of the two occurrences I managed, for the other it might require adapting the other create, I haven't found a proper way.