fix: do not trigger on views in ContainsPostgresTable#1001
Merged
JelteF merged 2 commits intoduckdb:mainfrom Jan 5, 2026
Merged
fix: do not trigger on views in ContainsPostgresTable#1001JelteF merged 2 commits intoduckdb:mainfrom
JelteF merged 2 commits intoduckdb:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the ContainsPostgresTable function was incorrectly triggering on database views. The fix adds a check to skip views when determining if a query contains Postgres tables.
Key Changes
- Updated duckdb submodule to a newer commit
- Added filtering logic to exclude views (RELKIND_VIEW) from Postgres table detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| third_party/duckdb | Updated submodule commit reference |
| src/pgduckdb_hooks.cpp | Added view detection to skip views in ContainsPostgresTable function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (rte->relid == InvalidOid) { | ||
| continue; | ||
| } | ||
| char relkind = get_rel_relkind(rte->relid); |
There was a problem hiding this comment.
The function get_rel_relkind can return 0 if the relation OID is invalid or the relation doesn't exist. This should be checked before comparing against RELKIND_VIEW to avoid silently skipping error cases. Consider adding a check for relkind == 0 and handling it appropriately.
Suggested change
| char relkind = get_rel_relkind(rte->relid); | |
| char relkind = get_rel_relkind(rte->relid); | |
| /* get_rel_relkind() returns 0 if the relation does not exist or OID is invalid. | |
| * Treat such cases as Postgres tables to avoid silently skipping an error. */ | |
| if (relkind == 0) { | |
| return true; | |
| } |
87530ef to
de3645f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1000