Do not set max_memory if given the empty string#614
Merged
Conversation
This was already the intended behaviour, as the already existing NULL check shows. The value of a GUC is never NULL though, but can be an empty string. This keeps the NULL check for safety purposes.
Y--
approved these changes
Feb 18, 2025
JelteF
added a commit
that referenced
this pull request
Mar 13, 2025
I made dumb mistake in #614. I accidentally checked the opposite of what intended to check. This fixes that and adds a test to confirm that the new behaviour is now correct.
JelteF
added a commit
that referenced
this pull request
Mar 13, 2025
I made dumb mistake in #614. I accidentally checked the opposite of what intended to check. This fixes that and adds a test to confirm that the new behaviour is now correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already the intended behaviour, as the already existing NULL check shows. The value of a GUC is never NULL though, but can be an empty string. This keeps the NULL check for safety purposes.