Handle PG columns with arrays with 0 dimensions correctly#616
Merged
Conversation
Y--
approved these changes
Feb 21, 2025
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was found in #556 sometimes array columns in Postgres are listed to have 0 dimensions, that's obviously because of missing information. This PR starts assuming that those arrays have a single dimension (because single dimension arrays are the most common type).
Given that that guess can obviously be wrong too. This adds the limitations that our multi-dimensional array support currently has in our docs.
Fixes #556