Skip to content

Fix crash on SAVEPOINT is not supported #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix crash on SAVEPOINT is not supported #763

wants to merge 1 commit into from

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented May 7, 2025

Fixes #761

@JelteF
Copy link
Collaborator

JelteF commented May 7, 2025

Some thoughts: I think this direction could very well be the correct solution. I'd like to discuss this on the Postgres mailing list first though, since this only became a problem in PG17.

Two main thoughts that I'd like to write down:

  1. If we do this approach, we should error earlier. e.g. in the executor/planner hook. Not only when actually executing something.
  2. Another idea that I think would obsolete this, is to actually allow some SAVEPOINT usages in combination with duckdb. As long as people don't use ROLLBACK TO SAVEPOINT to rollback changes from a DuckDB transaction, then there's no reason why we couldn't support that. So basically the idea would be to allow creating savepoints in transaction that did duckdb queries, but when a rollback to a savepoint happens we need to make sure all duckdb changes were before that savepoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend crash on Not implemented Error: SAVEPOINT is not supported in DuckDB
2 participants