wip: build pg_duckdb_cnpg image #972
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I had hoped that it would test the CI, but unfortunately the docker build fails when logging in to docker hub with What can I do to test that? |
ibotty
force-pushed
the
cnpg-image
branch
2 times, most recently
from
16a701f to
a6b553e
Compare
Collaborator
|
I pushed a change that I think should fix these docker build steps on PRs. |
Author
I could have figured that out by myself. Thank you. |
Author
|
The CI is green, but I can't know whether this is really working after it is merged I suppose. What do you think so far? Where should I add a sample |
Author
|
Can I do something to bring that to completion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #969.