Skip to content

Conversation

@CarterFendley
Copy link

This PR contains the changes made first to dask-groupby for dask-join. Notable features:

  • Extracts a common QueryRunner shared between both groupby and join.
  • Moves the question variables into a class attribute to maintain better encapsulation (example here).
  • Change file names to standard python conventions
    • Renames groupby-dask.py -> groupby_dask.py
    • Renames join-dask.py -> join_dask.py
  • Addition of a default "local" value for MACHINE_TYPE see here.

@Tmonster
Copy link
Collaborator

LGTM. Thanks!

@Tmonster Tmonster merged commit 873a7ab into duckdblabs:main Mar 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants