Custom Tab: Remove the legacy omnibar layout #7165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0nko
requested review from
anikiki
and removed request for
malmstein and
mikescamell
malmstein
approved these changes
Nov 21, 2025
Contributor
malmstein
left a comment
malmstein
left a comment
There was a problem hiding this comment.
Works as expected. I’ve tested the update scenario and it worked for me, just flagging it here.
| * sub-feature flag enabled | ||
| * If the remote feature is not present defaults to `true` | ||
| */ | ||
| @Toggle.DefaultValue(DefaultFeatureValue.TRUE) |
Contributor
There was a problem hiding this comment.
nit: is this going to affect updates? It worked well for me, but just wanted to raise it in case you haven’t tested that scenario.
| android:outlineProvider="none" | ||
| app:omnibarPosition="top" /> | ||
|
|
||
| <com.duckduckgo.app.browser.omnibar.SingleOmnibarLayout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211972481043747?focus=true
Description
This PR removes the
LegacyOmnibarLayoutandSplitOmnibarLayout, which are not used anymore, and all associated logic, including theuseUnifiedOmnibarLayoutfeature flag.Steps to test this PR
QA-optional or a simple smoke test, changing the omnibar position is enough.