Open
Conversation
d99ebea to
e8e8c85
Compare
Contributor
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1205278999335242/task/1213494024530409?focus=true
Tech Design URL:
CC:
Description
Removed temp pixels.
Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Low risk: removes debug/telemetry-only pixel firing and associated metadata without changing core scan/opt-out execution flow. Main risk is reduced observability if the typed-fallback situation still occurs in production.
Overview
Removes the temporary telemetry for detecting when broker action payloads fall back from raw JSON to typed encoding.
This deletes the
actionPayloadTypedFallbackUnexpectedpixel end-to-end (shared pixel enum/mapping, iOS/macOS pixel definitions) and removes the opt-out email-confirmation continuation exception tracking fromActionsHandler, along with the corresponding unit tests.Reviewed by Cursor Bugbot for commit e8e8c85. Bugbot is set up for automated code reviews on this repo. Configure here.