[iOS] Implement pixels for fire mode #4437
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1548,6 +1548,7 @@ | |
| let bucket = HomePageDisplayDailyPixelBucket(favoritesCount: favoritesCount) | ||
| DailyPixel.fire(pixel: .newTabPageDisplayedDaily, withAdditionalParameters: [ | ||
| "FavoriteCount": bucket.value, | ||
| PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue | ||
| ]) | ||
| } | ||
|
|
||
|
|
@@ -1577,8 +1578,9 @@ | |
| ) | ||
| } | ||
|
|
||
| let browsingModeParam = [PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue] | ||
| Pixel.fire(pixel: .forgetAllPressedBrowsing, withAdditionalParameters: browsingModeParam) | ||
| DailyPixel.fire(pixel: .forgetAllPressedBrowsingDaily, withAdditionalParameters: browsingModeParam) | ||
|
|
||
| performActionIfAITab { DailyPixel.fireDailyAndCount(pixel: .aiChatFireButtonTapped) } | ||
|
|
||
|
|
@@ -3029,8 +3031,8 @@ | |
| action() | ||
| } | ||
|
|
||
| func navigateToFireMode(source: FireModeSwitchSource = .internal) { | ||
| tabManager.setBrowsingMode(.fire, source: source) | ||
| showTabSwitcher() | ||
| } | ||
| } | ||
|
|
@@ -3401,14 +3403,15 @@ | |
|
|
||
| tab.didLaunchBrowsingMenu() | ||
|
|
||
| let modeParam = [PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue] | ||
| switch context { | ||
| case .newTabPage: | ||
| Pixel.fire(pixel: .browsingMenuOpenedNewTabPage) | ||
| case .aiChatTab: | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| Pixel.fire(pixel: .browsingMenuOpened, withAdditionalParameters: modeParam) | ||
| DailyPixel.fireDailyAndCount(pixel: .aiChatSettingsMenuOpened) | ||
| case .website: | ||
| Pixel.fire(pixel: .browsingMenuOpened, withAdditionalParameters: modeParam) | ||
|
|
||
| if tab.isError { | ||
| Pixel.fire(pixel: .browsingMenuOpenedError) | ||
|
|
@@ -3565,16 +3568,17 @@ | |
| aiChat: .keyboardGoWhileOnAIChat) | ||
| } | ||
|
|
||
| func fireControllerAwarePixel(ntp: Pixel.Event, serp: Pixel.Event, website: Pixel.Event, aiChat: Pixel.Event, | ||
| additionalParameters: [String: String] = [:]) { | ||
| if newTabPageViewController != nil { | ||
| Pixel.fire(pixel: ntp, withAdditionalParameters: additionalParameters) | ||
| } else if let currentTab { | ||
| if currentTab.isAITab == true { | ||
| Pixel.fire(pixel: aiChat, withAdditionalParameters: additionalParameters) | ||
| } else if currentTab.url?.isDuckDuckGoSearch == true { | ||
| Pixel.fire(pixel: serp, withAdditionalParameters: additionalParameters) | ||
| } else { | ||
| Pixel.fire(pixel: website, withAdditionalParameters: additionalParameters) | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -3599,7 +3603,7 @@ | |
| if featureFlagger.internalUserDecider.isInternalUser || isDebugBuild { | ||
| segueToDebugSettings() | ||
| } else { | ||
| segueToSettings() | ||
|
Check failure on line 3606 in iOS/DuckDuckGo/MainViewController.swift
|
||
| } | ||
| } | ||
|
|
||
|
|
@@ -3649,21 +3653,21 @@ | |
| } | ||
|
|
||
| private func newTabShortcutAction() { | ||
| Pixel.fire(pixel: .tabSwitchLongPressNewTab, withAdditionalParameters: [ | ||
| PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue | ||
| ]) | ||
| performCancel() | ||
| newTab() | ||
| } | ||
|
|
||
| private func newFireTabLongPressMenuAction() { | ||
| tabManager.setBrowsingMode(.fire, source: .longPressTabsIcon) | ||
| performCancel() | ||
| newTab() | ||
| } | ||
|
|
||
| private func newNormalTabLongPressMenuAction() { | ||
| tabManager.setBrowsingMode(.normal, source: .longPressTabsIcon) | ||
| performCancel() | ||
| newTab() | ||
| } | ||
|
|
@@ -3687,10 +3691,12 @@ | |
| } | ||
|
|
||
| if tapped { | ||
| let modeParam = [PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue] | ||
| fireControllerAwarePixel(ntp: .addressBarClickOnNTP, | ||
| serp: .addressBarClickOnSERP, | ||
| website: .addressBarClickOnWebsite, | ||
| aiChat: .addressBarClickOnAIChat, | ||
| additionalParameters: modeParam) | ||
| } | ||
|
|
||
| guard newTabPageViewController == nil else { return } | ||
|
|
@@ -3938,10 +3944,12 @@ | |
|
|
||
| // MARK: - Experimental Address Bar (pixels only) | ||
| func onExperimentalAddressBarTapped() { | ||
| let modeParam = [PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue] | ||
| fireControllerAwarePixel(ntp: .addressBarClickOnNTP, | ||
| serp: .addressBarClickOnSERP, | ||
| website: .addressBarClickOnWebsite, | ||
| aiChat: .addressBarClickOnAIChat, | ||
| additionalParameters: modeParam) | ||
| } | ||
|
|
||
| func onExperimentalAddressBarClearPressed() { | ||
|
|
@@ -3969,7 +3977,9 @@ | |
|
|
||
| /// Delegate method called when the omnibar branding area is tapped while in AI Chat mode. | ||
| func onAIChatBrandingPressed() { | ||
| Pixel.fire(pixel: .addressBarClickOnAIChat, withAdditionalParameters: [ | ||
| PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue | ||
| ]) | ||
| viewCoordinator.omniBar.beginEditing(animated: true, forTextEntryMode: .aiChat) | ||
| } | ||
|
|
||
|
|
@@ -4049,7 +4059,7 @@ | |
| } | ||
|
|
||
| func onFireModeRequested() { | ||
| navigateToFireMode(source: .ntpPromotion) | ||
| } | ||
|
|
||
| func isCurrentTabFireTab() -> Bool { | ||
|
|
@@ -4171,7 +4181,7 @@ | |
| } | ||
|
|
||
| func newTabPageDidRequestFireMode(_ controller: NewTabPageViewController) { | ||
| navigateToFireMode(source: .ntpPromotion) | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -4186,7 +4196,7 @@ | |
| } | ||
|
|
||
| func tabDidRequestFireMode(tab: TabViewController) { | ||
| navigateToFireMode(source: .menuPromotion) | ||
| } | ||
|
|
||
| var isAIChatEnabled: Bool { | ||
|
|
@@ -4272,7 +4282,7 @@ | |
| func tab(_ tab: TabViewController, | ||
| didRequestNewFireTabForUrl url: URL, | ||
| inheritingAttribution attribution: AdClickAttributionLogic.State?) { | ||
| tabManager.setBrowsingMode(.fire, source: .longPressLink) | ||
| loadUrlInNewTab(url, inheritedAttribution: attribution) | ||
| } | ||
|
|
||
|
|
@@ -4714,8 +4724,11 @@ | |
| } | ||
|
|
||
| func showTabSwitcher(_ button: TabSwitcherButton) { | ||
| Pixel.fire(pixel: .tabBarTabSwitcherOpened, | ||
| withAdditionalParameters: [PixelParameters.browsingMode: tabManager.currentBrowsingMode.pixelParamValue]) | ||
| var openedDailyParams = TabSwitcherOpenDailyPixel().parameters(with: tabManager.allTabsModel.tabs) | ||
| openedDailyParams[PixelParameters.browsingMode] = tabManager.currentBrowsingMode.pixelParamValue | ||
| DailyPixel.fireDaily(.tabSwitcherOpenedDaily, withAdditionalParameters: openedDailyParams) | ||
|
|
||
| performActionIfAITab { DailyPixel.fireDailyAndCount(pixel: .aiChatTabSwitcherOpened) } | ||
|
|
||
|
|
@@ -4949,6 +4962,7 @@ | |
| extension MainViewController: TabManagerFireModeDelegate { | ||
|
|
||
| func tabManagerDidCloseLastFireTab() { | ||
| DailyPixel.fireDailyAndCount(pixel: .fireModeLastTabClosedBurn) | ||
| Task { | ||
| let request = FireRequest(options: [.data, .aiChats], | ||
| trigger: .fireModeAutoClear, | ||
|
|
@@ -4983,20 +4997,23 @@ | |
|
|
||
| private func firePixels(for request: FireRequest) { | ||
| let tabType = tabManager.viewModelForCurrentTab()?.tab.isAITab == true ? "ai" : "web" | ||
| let browsingMode = tabManager.currentBrowsingMode.pixelParamValue | ||
| let params: [String: String] = [ | ||
| PixelParameters.source: request.source.rawValue, | ||
| PixelParameters.tabType: tabType, | ||
| PixelParameters.browsingMode: browsingMode | ||
| ] | ||
|
|
||
| switch request.scope { | ||
| case .all: | ||
| Pixel.fire(pixel: .forgetAllExecuted, withAdditionalParameters: params) | ||
| DailyPixel.fire(pixel: .forgetAllExecutedDaily, withAdditionalParameters: params) | ||
| case .tab: | ||
| DailyPixel.fireDailyAndCount(pixel: .singleTabBurnExecuted, withAdditionalParameters: params) | ||
| case .fireMode: | ||
| DailyPixel.fireDailyAndCount(pixel: .fireModeBurnExecuted, withAdditionalParameters: params) | ||
| case .normalMode: | ||
| DailyPixel.fireDailyAndCount(pixel: .normalModeBurnExecuted, withAdditionalParameters: params) | ||
|
Contributor
There was a problem hiding this comment. Browsing mode may be stale for scoped burnsMedium Severity In Please tell me if this was useful or not with a 👍 or 👎.   Reviewed by Cursor Bugbot for commit 2ff6b0a. Configure here. |
||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.