Open
Conversation
Contributor
Contributor
🌍 Smartling Translation Job CreatedJob ID: Next:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1214011006484552?focus=true
Tech Design URL:
CC:
Description
This PR adds translations for the fire mode feature
Testing Steps
No testing required
Impact and Risks
None: Internal tooling, documentation
What could go wrong?
N/A
Quality Considerations
N/A
Notes to Reviewer
N/A
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Low risk: this PR only switches Fire Mode-related copy from
NotLocalizedStringtoNSLocalizedStringand adds the corresponding English keys, with no behavior or data-flow changes.Overview
Adds localization support for Fire Mode UI copy by replacing several Fire Tab/Fire Mode strings in
UserText.swiftfromNotLocalizedStringtoNSLocalizedString.Populates
en.lproj/Localizable.stringswith the new keys covering Fire Tab actions, empty-state and promo text, scoped fire confirmation title, escape hatch label, and tab-switcher accessibility labels.Reviewed by Cursor Bugbot for commit 4be6092. Bugbot is set up for automated code reviews on this repo. Configure here.