Skip to content

[iOS] Add fire mode translations#4438

Open
hassaanelgarem wants to merge 1 commit intomainfrom
hassaan/fire-mode/translations
Open

[iOS] Add fire mode translations#4438
hassaanelgarem wants to merge 1 commit intomainfrom
hassaan/fire-mode/translations

Conversation

@hassaanelgarem
Copy link
Copy Markdown
Contributor

@hassaanelgarem hassaanelgarem commented Apr 11, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1214011006484552?focus=true
Tech Design URL:
CC:

Description

This PR adds translations for the fire mode feature

Testing Steps

No testing required

Impact and Risks

None: Internal tooling, documentation

What could go wrong?

N/A

Quality Considerations

N/A

Notes to Reviewer

N/A


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Low Risk
Low risk: this PR only switches Fire Mode-related copy from NotLocalizedString to NSLocalizedString and adds the corresponding English keys, with no behavior or data-flow changes.

Overview
Adds localization support for Fire Mode UI copy by replacing several Fire Tab/Fire Mode strings in UserText.swift from NotLocalizedString to NSLocalizedString.

Populates en.lproj/Localizable.strings with the new keys covering Fire Tab actions, empty-state and promo text, scoped fire confirmation title, escape hatch label, and tab-switcher accessibility labels.

Reviewed by Cursor Bugbot for commit 4be6092. Bugbot is set up for automated code reviews on this repo. Configure here.

@hassaanelgarem hassaanelgarem self-assigned this Apr 11, 2026
@hassaanelgarem hassaanelgarem added start ios translation Starts iOS translation workflow via Smartling do-not-autoclose Prevents auto-closing by stale PR workflow. labels Apr 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See iOS and macOS localization guidelines for more information.

Generated by 🚫 dangerJS against 4be6092

@github-actions
Copy link
Copy Markdown
Contributor

🌍 Smartling Translation Job Created

Job ID: xkbbcdz4lixw
Platform: iOS

🔗 View in Smartling Dashboard

🔧 View Workflow Run

Next:

  • Review translation job
  • Authorize translation by adding the authorize translation label

@github-actions github-actions bot added needs translation authorization The Smartling translation job the PR is awaiting authorization. and removed start ios translation Starts iOS translation workflow via Smartling labels Apr 11, 2026
@hassaanelgarem hassaanelgarem added translation in progress The strings in this PR are being translated on Smartling and removed needs translation authorization The Smartling translation job the PR is awaiting authorization. labels Apr 11, 2026
@hassaanelgarem hassaanelgarem added download translations Downloads and imports translations for this PR from Smartling and removed translation in progress The strings in this PR are being translated on Smartling labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-autoclose Prevents auto-closing by stale PR workflow. download translations Downloads and imports translations for this PR from Smartling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant