[iOS] New import actions wired up#4446
Open
amddg44 wants to merge 20 commits intoanya/data-import-revamp-entrypointfrom
Open
[iOS] New import actions wired up#4446amddg44 wants to merge 20 commits intoanya/data-import-revamp-entrypointfrom
amddg44 wants to merge 20 commits intoanya/data-import-revamp-entrypointfrom
Conversation
… upload support across different import screens
Base automatically changed from
anya/new-import-passwords
to
anya/data-import-revamp-entrypoint
April 16, 2026 11:01
…t-passwords-actions
…nt' into anya/new-import-passwords-actions # Conflicts: # iOS/DuckDuckGo-iOS.xcodeproj/project.pbxproj
…nt' into anya/new-import-passwords-actions
Contributor
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1f1b844. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL:
Tech Design URL:
CC:
Description
Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Medium Risk
Adds new password import entry points (file upload flow, Safari export interstitial, and ASCredentialExchange-based imports) that touch secure vault importing and app-wide user-activity handling. Risk is moderate due to new OS-version-gated flows and potential import/UX regressions, but changes are largely additive and guarded by availability checks.
Overview
Enables the new Data Import Hub flow end-to-end: hub screens can now start a file-upload import via a new
DataImportFileUploadCoordinator, show a Safari export interstitial, and trigger BrowserKit’s import request from the Safari detail screen.Adds support for ASCredentialExchange password imports by advertising extension/app capabilities in
Info.plist, introducingCredentialExchangeImportHandlerto convertASExportedCredentialDatainto vault logins, and extendingDataImportUserActivityHandler/MainCoordinatorto process credential-exchange user activities and present aDataImportSummaryViewController.Updates existing entry points (autofill login list/settings, bookmarks, main data import launch, and settings legacy provider/view model) to pass required dependencies into
DataImportHubViewControllerand to run consistent “import finished” callbacks/refresh behavior.Reviewed by Cursor Bugbot for commit 1f1b844. Bugbot is set up for automated code reviews on this repo. Configure here.