Skip to content

[iOS] New import actions wired up#4446

Open
amddg44 wants to merge 20 commits intoanya/data-import-revamp-entrypointfrom
anya/new-import-passwords-actions
Open

[iOS] New import actions wired up#4446
amddg44 wants to merge 20 commits intoanya/data-import-revamp-entrypointfrom
anya/new-import-passwords-actions

Conversation

@amddg44
Copy link
Copy Markdown
Contributor

@amddg44 amddg44 commented Apr 13, 2026

Task/Issue URL:
Tech Design URL:
CC:

Description

Testing Steps

Impact and Risks

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Medium Risk
Adds new password import entry points (file upload flow, Safari export interstitial, and ASCredentialExchange-based imports) that touch secure vault importing and app-wide user-activity handling. Risk is moderate due to new OS-version-gated flows and potential import/UX regressions, but changes are largely additive and guarded by availability checks.

Overview
Enables the new Data Import Hub flow end-to-end: hub screens can now start a file-upload import via a new DataImportFileUploadCoordinator, show a Safari export interstitial, and trigger BrowserKit’s import request from the Safari detail screen.

Adds support for ASCredentialExchange password imports by advertising extension/app capabilities in Info.plist, introducing CredentialExchangeImportHandler to convert ASExportedCredentialData into vault logins, and extending DataImportUserActivityHandler/MainCoordinator to process credential-exchange user activities and present a DataImportSummaryViewController.

Updates existing entry points (autofill login list/settings, bookmarks, main data import launch, and settings legacy provider/view model) to pass required dependencies into DataImportHubViewController and to run consistent “import finished” callbacks/refresh behavior.

Reviewed by Cursor Bugbot for commit 1f1b844. Bugbot is set up for automated code reviews on this repo. Configure here.

Base automatically changed from anya/new-import-passwords to anya/data-import-revamp-entrypoint April 16, 2026 11:01
@amddg44 amddg44 marked this pull request as ready for review April 19, 2026 21:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 19, 2026

Fails
🚫 Please, don't forget to add a link to the internal task
Warnings
⚠️ PR has 1845 lines of added code (excluding Xcode projects and assets). Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See iOS and macOS localization guidelines for more information.

Generated by 🚫 dangerJS against 1f1b844

Comment thread iOS/DuckDuckGo/DataImport/DataImportUserActivityHandler.swift
Comment thread iOS/DuckDuckGo/DataImport/Hub/ImportSourceDetailViewController.swift Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1f1b844. Configure here.

Comment thread iOS/DuckDuckGo/Info.plist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant