Redesign macOS contextual SearchDone dialog for rebranding#4454
Redesign macOS contextual SearchDone dialog for rebranding#4454afterxleep wants to merge 5 commits intomainfrom
Conversation
Replace legacy DaxDialogView with OnboardingBubbleView for the TrySearch dialog. Update theme with new typography, colors, pill-shaped buttons, and bubble metrics. Add spot illustration background with fixed 208pt panel height. All changes gated behind .onboardingRebranding feature flag.
The parameter was added but never used — the macOS factory builds its own background ZStack instead of using the shared modifier. Also includes SPM Package.resolved update.
Introduces custom CTA button colors and styling for the macOS contextual onboarding dialogs to match the rebranding design.
- Add reusable CTAButtonStyle with hover/press states for macOS - Redesign SearchDone dialog using OnboardingBubbleView and rebranded components - Replace SearchDone background illustrations with updated macOS assets - Move background images to .background() modifier to prevent layout interference - Vertically center bubbles using spacers in both TrySearch and SearchDone panels
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 39f0ce1. Configure here.
| ) | ||
| .clipped() | ||
| .applyOnboardingTheme(.macOSRebranding2026) | ||
| ) |
There was a problem hiding this comment.
Fixed panel height clips SearchDone follow-up content
Medium Severity
The .searchDone case wraps the dialog in a VStack with .frame(height: 180) and .clipped(). When OnboardingSearchDoneDialog internally transitions to OnboardingTrySiteDialogContent (via showNextScreen = true), the TrySite content — which includes a title, message, and a list of site suggestions — remains constrained to this 180-point container. With the bubble's contentInsets consuming 48 points vertically (24 top + 24 bottom), plus the tail, border, and shadow, very little space remains for the TrySite list items. Previously, no fixed height was applied, allowing the view to expand naturally to fit the follow-up content.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 39f0ce1. Configure here.
1 participant
Summary
CTAButtonStylewith hover/press states for macOS onboarding screensOnboardingBubbleViewand rebrandedContextualDaxDialogContentcomponents.background()modifier so they don't inflate the ZStack's natural size and interfere with bubble positioningTest plan
Note
Medium Risk
Mostly UI/layout and theme tweaks for macOS contextual onboarding, but it changes shared theme metrics and button styles that could subtly affect other onboarding screens’ appearance and interaction states.
Overview
Redesigns the macOS rebranded contextual onboarding panels for
TrySearchandSearchDoneby switching dialogs toOnboardingBubbleView+ rebrandedContextualDaxDialogContent, vertically centering the bubble, and rendering new illustration-based backgrounds via.background()with fixed panel heights.Adds a reusable rebranded
CTAButtonStyle(pressed/hover states) and updates the macOS rebranding theme to use new typography, colors, primary button styling, and configurable option-list padding/metrics (plumbed throughOptionsListMetricsand consumed byListButtonStyle).Reviewed by Cursor Bugbot for commit 39f0ce1. Bugbot is set up for automated code reviews on this repo. Configure here.