Skip to content

Fix escape hatch showing URL instead of page title on cold start #4456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SabrinaTardio merged 3 commits into from
Apr 21, 2026
+3 −1
Merged

Fix escape hatch showing URL instead of page title on cold start #4456

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee42e6
Fix escape hatch showing URL instead of page title on cold start
SabrinaTardio Apr 14, 2026
a124e4e
Guard title preservation against URL changes
SabrinaTardio Apr 14, 2026
19de876
Also handle empty title to match Link.merge(with:)
SabrinaTardio Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion iOS/DuckDuckGo/TabViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,8 @@ class TabViewController: UIViewController {

func updateTabModel() {
if let url = url {
let link = Link(title: title, url: url)
let previousTitle = (tabModel.link?.url == url) ? tabModel.link?.title : nil
let link = Link(title: title ?? previousTitle, url: url)
Comment thread
SabrinaTardio marked this conversation as resolved.
Outdated
tabModel.link = link
} else {
tabModel.link = nil
Expand Down
Loading