remove downloads storyboard and other minor clean up#4458
Open
remove downloads storyboard and other minor clean up#4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1200194497630846/task/1213916260872783?focus=true
Tech Design URL:
CC:
Description
Remove downloads storyboard.
Testing Steps
Impact and Risks
Low: Minor visual changes, small bug fixes, improvement to existing features
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Medium Risk
Mostly a UI navigation refactor, but it also upgrades
content-scope-scriptsto a new major version which could affect content blocking behavior at runtime.Overview
Removes
Downloads.storyboardfrom the project and updatessegueToDownloads()to presentDownloadsListHostingController()directly instead of instantiating a storyboard.Updates
DownloadsListHostingControllerto be initializer-driven (noinit(coder:)support) and performs minor appearance setup cleanup. Separately bumps the SwiftPMcontent-scope-scriptsdependency from13.41.0to14.0.0inPackage.resolved.Reviewed by Cursor Bugbot for commit b0ade0a. Bugbot is set up for automated code reviews on this repo. Configure here.