Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1199333091098016/task/1214087783608728?focus=true
Tech Design URL:
CC:
Description
PIR E2E tests are one of the most-used xlarge runner workflows. We should be safe to downgrade these to the free runner.
Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Medium Risk
Medium risk because it changes the GitHub Actions runner size for a frequently used e2e workflow, which could increase runtime or cause new timeouts/resource-related flakes.
Overview
Switches the macOS PIR end-to-end GitHub Actions workflow from the
macos-26-xlargerunner to the standardmacos-26runner (including the matrix include entry), reducing CI runner cost/usage while keeping the rest of the workflow behavior the same.Reviewed by Cursor Bugbot for commit 7fafd7e. Bugbot is set up for automated code reviews on this repo. Configure here.