Skip to content

[IOS][Onboarding Rebranding Animations] Fix bubble linear positioning and bold font for trackers#4470

Open
alessandroboron wants to merge 5 commits intofcappelli/onboarding.rebrand.naimations.2from
alessandro/dax-animations-batch-fixes
Open

[IOS][Onboarding Rebranding Animations] Fix bubble linear positioning and bold font for trackers#4470
alessandroboron wants to merge 5 commits intofcappelli/onboarding.rebrand.naimations.2from
alessandro/dax-animations-batch-fixes

Conversation

@alessandroboron
Copy link
Copy Markdown
Contributor

@alessandroboron alessandroboron commented Apr 17, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214073565693402
Tech Design URL:
CC:

Description

This PR addresses:

Testing Steps

  1. Launch Rebranded onboarding.
  2. Verify that between step 3 4 and 5 of the linear flow the bubble vertical position stays the same.
  3. Verify that trackers blocked showed in bold.

Impact and Risks

Low: These are visual changes fixes

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Low Risk
Low risk UI-only changes: updates the typing animation to operate on AttributedString and tweaks onboarding layout sizing and test mocks, with minimal impact outside presentation and animation behavior.

Overview
Improves rebranded onboarding text rendering and layout stability. TypingText now animates AttributedString directly (with a String convenience init), and contextual Dax dialog content passes attributed title/message through the typing animation so markdown/bold styling is preserved during reveal.

Also fixes a linear onboarding layout issue by constraining the address bar position picker buttons to a fixed height (min+max), and extends MockOmniBar with long-press callbacks for menu/settings buttons to match updated UI interactions.

Reviewed by Cursor Bugbot for commit 68c5140. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ee1e38. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant