[IOS][Onboarding Rebranding Animations] Fix bubble linear positioning and bold font for trackers#4470
Open
alessandroboron wants to merge 5 commits intofcappelli/onboarding.rebrand.naimations.2from
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2ee1e38. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214073565693402
Tech Design URL:
CC:
Description
This PR addresses:
Testing Steps
Impact and Risks
Low: These are visual changes fixes
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Low risk UI-only changes: updates the typing animation to operate on
AttributedStringand tweaks onboarding layout sizing and test mocks, with minimal impact outside presentation and animation behavior.Overview
Improves rebranded onboarding text rendering and layout stability.
TypingTextnow animatesAttributedStringdirectly (with aStringconvenience init), and contextual Dax dialog content passes attributed title/message through the typing animation so markdown/bold styling is preserved during reveal.Also fixes a linear onboarding layout issue by constraining the address bar position picker buttons to a fixed height (min+max), and extends
MockOmniBarwith long-press callbacks for menu/settings buttons to match updated UI interactions.Reviewed by Cursor Bugbot for commit 68c5140. Bugbot is set up for automated code reviews on this repo. Configure here.