[iOS] Localize Duck.ai contextual sheet strings for Smartling translation#4474
Open
SabrinaTardio wants to merge 1 commit intosabrina/view-all-chats-url-parameterfrom
Open
Conversation
Contributor
Contributor
🌍 Smartling Translation Job CreatedJob ID: Next:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1204186595873227/task/1214118261014133?focus=true
Tech Design URL: N/A
CC: N/A
Description
NotLocalizedStringentries toNSLocalizedStringfor Smartling translation: welcome message, quick actions, recent chats popup labels"All chats are %@ private") with a separate highlighted word string, so translators can reorder for their languagesearchInputFieldPlaceholderDuckAIV2since the original now uses the updated copyTesting Steps
Impact and Risks
Impact Level: Low
What could go wrong?
Quality Considerations
%@placeholder for the shield icon, allowing translators to reposition itduckai.welcome.private.wordstring ensures translators can keep the highlighted word in sync with the full messageaiChatRecentChatsTitle,aiChatSuggestedChatsTitle) intentionally left asNotLocalizedStringsince they're not part of the contextual sheetMade with Cursor
Note
Low Risk
Low risk UI copy/localization changes; main risk is the new welcome-message format/keyword matching, which could affect icon insertion or green highlighting in some locales.
Overview
Updates Duck.ai contextual sheet copy to be fully localizable via
NSLocalizedString, adding new keys for the welcome message, quick actions, and recent-chats labels.Refactors the welcome label to use a single format string (
"All chats are %@ private") with runtime shield-icon replacement and separate localized matching for the highlighted private word, and standardizes the input placeholder to the updated copy ("Ask anything privately") while removing the old V2 placeholder/flagged selection.Reviewed by Cursor Bugbot for commit f4c504c. Bugbot is set up for automated code reviews on this repo. Configure here.