[macOS] Improve geolocation provider test reliability#4475
Open
[macOS] Improve geolocation provider test reliability#4475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1214132819416367?focus=true
Tech Design URL:
CC:
Description
This PR improves reliability of geolocation provider tests by making sure that the test waits for the appropriate events to complete before asserting any state.
Testing Steps
Impact and Risks
What could go wrong?
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Low risk because it only adjusts unit test coordination logic; main risk is altering test ordering assumptions and potentially masking a real concurrency issue if the new gating is incorrect.
Overview
Improves reliability of
GeolocationProviderTestsby changing the multi-webview pause scenario to wait until both web views have received the first location before pausingwebView2and publishing the second location.This replaces a subscription-history-based trigger with explicit per-webview receipt flags, reducing race conditions in
testWhenOneWebViewGeolocationIsPausedThenAnotherWebViewContinuesReceivingLocationUpdates().Reviewed by Cursor Bugbot for commit 1cd261a. Bugbot is set up for automated code reviews on this repo. Configure here.