Skip to content

[macOS] Improve geolocation provider test reliability#4475

Open
samsymons wants to merge 1 commit intomainfrom
sam/fix-flaky-macos-geolocation-test
Open

[macOS] Improve geolocation provider test reliability#4475
samsymons wants to merge 1 commit intomainfrom
sam/fix-flaky-macos-geolocation-test

Conversation

@samsymons
Copy link
Copy Markdown
Collaborator

@samsymons samsymons commented Apr 20, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1214132819416367?focus=true
Tech Design URL:
CC:

Description

This PR improves reliability of geolocation provider tests by making sure that the test waits for the appropriate events to complete before asserting any state.

Testing Steps

  1. Check that CI is green

Impact and Risks

What could go wrong?

Quality Considerations

Notes to Reviewer


Internal references:

Definition of Done | Engineering Expectations | Tech Design Template


Note

Low Risk
Low risk because it only adjusts unit test coordination logic; main risk is altering test ordering assumptions and potentially masking a real concurrency issue if the new gating is incorrect.

Overview
Improves reliability of GeolocationProviderTests by changing the multi-webview pause scenario to wait until both web views have received the first location before pausing webView2 and publishing the second location.

This replaces a subscription-history-based trigger with explicit per-webview receipt flags, reducing race conditions in testWhenOneWebViewGeolocationIsPausedThenAnotherWebViewContinuesReceivingLocationUpdates().

Reviewed by Cursor Bugbot for commit 1cd261a. Bugbot is set up for automated code reviews on this repo. Configure here.

@samsymons samsymons requested a review from mallexxx April 20, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant