Conversation
Collaborator
|
CI run finished. Artifacts ZIP for the review tool |
Collaborator
|
CI run finished. Artifacts ZIP for the review tool |
Collaborator
|
CI run finished. Artifacts ZIP for the review tool |
Collaborator
|
CI run finished. Artifacts ZIP for the review tool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1203268166580279/task/1210626500262515?focus=true
Description:
Steps to test this PR:
Note
Medium Risk
Behavior changes in CMP automation flows (OneTrust and TrustArc) can cause missed or incorrect opt-out interactions on affected sites, though scope is limited to selector/timeout tweaks and test updates.
Overview
Improves CMP opt-out robustness for OneTrust by adding a short delay and trying multiple reject-all selectors individually instead of a single combined check.
Updates TrustArc (iframe) opt-out to support an additional decline button selector and removes the early-return path that skipped opt-out when the self-test indicated an already-set state.
Extends Playwright coverage by adding new real-world sites to the OneTrust and TrustArc-frame test matrices.
Reviewed by Cursor Bugbot for commit a4f63a0. Bugbot is set up for automated code reviews on this repo. Configure here.