Skip to content

Comments

ntp: remove legacy menu#1638

Merged
shakyShane merged 3 commits intomainfrom
shane/ntp-legacy-menu
Apr 24, 2025
Merged

ntp: remove legacy menu#1638
shakyShane merged 3 commits intomainfrom
shane/ntp-legacy-menu

Conversation

@shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Apr 18, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1209698262999393/task/1210001582798249?focus=true

Description

  • during the initial roll out, we supported 2 kinds of customization: basic on/off for sections and then the full slide out panel. Now only the panel is supported, so this PR removes unused code paths :)

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit b9dcddb
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6809e9c26acd4b0008854a90
😎 Deploy Preview https://deploy-preview-1638--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

[Beta] Generated file diff

Time updated: Thu, 24 Apr 2025 07:36:12 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review April 18, 2025 13:00
@shakyShane shakyShane requested review from a team and mgurgel as code owners April 18, 2025 13:00
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shakyShane shakyShane merged commit 6f4e461 into main Apr 24, 2025
14 checks passed
@shakyShane shakyShane deleted the shane/ntp-legacy-menu branch April 24, 2025 11:29
mallexxx pushed a commit that referenced this pull request Jul 17, 2025
* ntp: remove legacy menu

* fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants