-
Notifications
You must be signed in to change notification settings - Fork 31
Server configuration cleanup #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removes the http-server dependency and simplifies the test harness by removing the need for a separate server process. Co-authored-by: jkingston <[email protected]>
|
Cursor Agent can help with this pull request. Just |
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Wed, 07 Jan 2026 14:36:20 GMT |
Asana Task/Github Issue: N/A
Description
Consolidates Playwright test server configurations by:
altServerPortfixture and its associated per-test forked server.webServerinstance, leveraging different hosts (localhostand127.0.0.1) on the same port for first-party separation.injected/scripts/server.mjs.This streamlines the test setup and removes redundant server logic introduced during the Playwright migration.
Testing Steps
npm run buildand ensureinjectedunit tests pass.npm run test-int-x -- --project chrome-mv3 --grep "Fingerprint"and ensure fingerprint Playwright tests pass.Checklist
Please tick all that apply:
Note
Streamlines Playwright server usage and simplifies fingerprint tests.
altServerPortfixture and per-test forked server fromhelpers/harness.js; deleteinjected/scripts/server.mjsTEST_PAGE_SERVER_PORTandTEST_PAGE_SERVER_BASE_URLinplaywright.config.jsand use them infingerprint.spec.jslocalhostand127.0.0.1on the same port for first‑party separation; drop unused{ altServerPort }params and console logswebServerWritten by Cursor Bugbot for commit e5102e9. This will update automatically on new commits. Configure here.