You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds NTP rebrand flag wiring to the New Tab Page settings contract.
This introduces settings.newTabPageRebranding, defaults it to disabled when absent, allows it through withFeatureState, exposes useNewTabPageRebranding(), and sets document.body.dataset.rebrand for CSS gating. Also adds ?rebrand=enabled mock support and integration coverage for the body data attribute.
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
I have ensured the change is gated by config
This change was covered by a ship review
This change was covered by a tech design
Any dependent config has been merged
Note
Low Risk
Flag plumbing and a body data attribute only; no user-visible rebrand UI yet and behavior stays off unless native config or mock enables it.
Overview
Adds config-driven wiring for a New Tab Page rebrand rollout: newTabPageRebranding is part of the initialSetup settings contract (JSON schema + generated types), merged via Settings / withFeatureState with a disabled default, and surfaced as useNewTabPageRebranding().
On init, the flag sets body[data-rebrand] to "true" or "false" so future rebrand CSS can gate on body[data-rebrand="true"] (placeholder rule added in App.module.css). Mock/dev flows support ?rebrand=enabled, and Playwright tests assert the body attribute default and when the mock param is on.
Reviewed by Cursor Bugbot for commit 2255ab0. Bugbot is set up for automated code reviews on this repo. Configure here.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Web Compatibility Assessment
No injected (injected/) or page-world API changes in this PR. All changes are confined to the special-pages New Tab app (settings wiring, a data-rebrand body attribute, an empty CSS placeholder, mock transport, and integration tests). From a web-compatibility perspective for third-party sites, this PR is a no-op — it does not run on arbitrary web pages.
File
Lines
Severity
Finding
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand follows the same installGlobalSideEffects pattern as existing data-platform-name / data-display / data-animation attributes. document.body is available after initialSetup() resolves. Default is "false".
Empty body[data-rebrand="true"] rule block has no layout or rendering impact today. Future styles added here should be tested across platforms (iOS/Android WebView quirks, reduced motion, theme variants).
useNtpRebrand() is exported but not yet consumed by components. Safe scaffolding; no runtime side effects until future PRs use it.
special-pages/pages/new-tab/app/settings.js
21, 49–61
info
Default ntpRebrand: { state: 'disabled' } and withFeatureState enum validation mirror adBlocking. Invalid or missing native values safely fall back to disabled.
No warnings or errors for web compatibility.
Security Assessment
No changes to messaging transports, message bridge, captured-globals, API overrides, or injected initialization. Security surface is limited to native→NTP settings delivery (existing trust boundary).
ntpRebrand.state restricted to "enabled" / "disabled" enum — consistent with adBlocking.
special-pages/pages/new-tab/app/mock-transport.js
617–619
info
?rebrand=enabled URL param only affects local dev / Playwright mock transport, not production native builds.
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand is a non-sensitive UI flag exposed on <body>. Same exposure model as other data-* attributes already set by NTP. No nativeData forwarding.
No warnings, errors, or critical findings for security.
Risk Level
Low Risk — Special-pages-only feature-flag scaffolding with safe defaults, schema validation, and integration test coverage; zero injected or messaging security surface changes.
Recommendations
(info) When rebrand CSS is populated in follow-up PRs, run visual QA across theme variants (themeVariant param), light/dark, and reduced-motion — the empty placeholder is harmless now but future rules could affect layout.
(info) Consider documenting ?rebrand=enabled in special-pages/pages/new-tab/readme.md alongside other feature URL params for local dev consistency (optional; other settings flags like ad-blocking are also undocumented).
(info) Verify native clients send ntpRebrand in initialSetup.settings before enabling the flag in production — C-S-S defaults to disabled when absent, which is the correct safe fallback.
Integration tests for the rebrand data attribute (defaults rebrand data attribute to false, sets rebrand data attribute from mock url param) pass locally.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Injected PR Evaluation: Web Compatibility & Security
PR: Add New Tab rebrand feature flag wiring (462bcd69) Scope:special-pages/pages/new-tab/ only — zero injected/, messaging/, or captured-globals changes.
Web Compatibility Assessment
File
Lines
Severity
Finding
(all)
—
info
No injected page-world code changes. This PR does not touch browser API overrides, prototype chains, or third-party script interaction surfaces. Web-compat evaluation categories for injected scripts are not applicable.
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand body attribute follows the established NTP pattern (data-platformName, data-display, data-animation). Safe CSS hook for gated rebrand styles.
useNewTabPageRebranding() hook is wired but not yet consumed by components — expected for a flag-wiring PR; no runtime behavior change until follow-up styling lands.
JSON Schema constrains newTabPageRebranding.state to enabled | disabled. Referenced by initialSetup.response.json for native→web validation.
special-pages/pages/new-tab/app/settings.js
21, 55–61
info
Defaults to { state: 'disabled' }; withFeatureState() double-checks state enum before applying native override. Fail-safe when flag is absent or invalid.
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand is a static "true"/"false" string derived from validated settings — no page-controlled input, no URL/data exfiltration vector.
special-pages/pages/new-tab/app/mock-transport.js
617–619
info
?rebrand=enabled URL param is dev/test mock transport only; not a production trust boundary.
No nativeData leakage, messaging transport changes, postMessage usage, dynamic code execution, or uncaptured-global concerns identified.
Risk Level
Low Risk — Special-pages-only feature-flag wiring with safe defaults, schema validation, and integration test coverage; no injected runtime, API shim, or messaging security surface changes.
Recommendations
(info) Coordinate native platform wiring so initialSetup.settings.newTabPageRebranding is populated in production builds (out of scope for this repo PR, but required for the flag to take effect).
(info) When rebrand styles land, consume useNewTabPageRebranding() in components and/or add rules under body[data-rebrand="true"] — the hook and attribute are ready.
(info) Integration tests for default/disabled and mock-enabled states pass locally (2/2 rebrand specs green).
Scope:special-pages/pages/new-tab only (+50/−2). No changes to injected/, messaging/ transports, wrapper-utils.js, captured-globals.js, or message-bridge security checks.
Web Compatibility Assessment
File
Lines
Severity
Finding
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand body attribute follows the existing data-animation / data-display pattern. Safe CSS hook; defaults to "false".
useNewTabPageRebranding() hook is defined but not yet consumed by components. Expected for a wiring-only PR.
No API overrides, prototype modifications, DOM timing hazards, or third-party script interaction concerns. NTP runs in DDG's embedded page context, not arbitrary third-party sites.
JSON Schema constrains newTabPageRebranding.state to enabled | disabled.
special-pages/pages/new-tab/app/settings.js
46–61
info
withFeatureState() validates enum before accepting native settings; invalid values are ignored, preserving constructor default (disabled).
special-pages/pages/new-tab/app/index.js
179
info
data-rebrand is derived from native-controlled initialSetup settings, not page/user input. No nativeData leakage or new messaging surface.
special-pages/pages/new-tab/app/mock-transport.js
617–619
info
?rebrand=enabled URL param is dev/mock-only; not a production attack surface.
No messaging trust-boundary changes, no uncaptured globals, no postMessage, no dynamic code execution.
Risk Level
Low Risk — Config-only feature-flag plumbing for the New Tab Page, mirroring the established adBlocking pattern, with no injected-script or messaging security surface changes.
Recommendations
Native wiring (out of scope): Ensure platform clients populate settings.newTabPageRebranding in initialSetup before enabling the flag in production.
Follow-up PRs: When adding rebrand styles to App.module.css, prefer design-system tokens (as in recent omnibar theming work) to avoid hardcoded colors.
Tests: Integration coverage for default false and mock enabled param passes (verified locally).
✅ No blocking web-compat or security issues for merge from an injected-scripts perspective.
The reason will be displayed to describe this comment to others. Learn more.
Injected PR Evaluation: Web Compatibility & Security
PR: Add New Tab rebrand feature flag wiring (5fa7306b) Scope:special-pages/pages/new-tab/ only — no injected/, messaging/, or API override changes.
Web Compatibility Assessment
File
Lines
Severity
Finding
(all)
—
info
Changes are confined to the first-party New Tab Page embedded app. No code runs in third-party page contexts, so injected-script compatibility categories (API fidelity, prototype chain, DOM safety on arbitrary sites) do not apply.
app/components/App.module.css
30–32
info
Empty body[data-rebrand="true"] placeholder — no visual or layout changes in this PR. Safe scaffolding for follow-up rebrand CSS.
app/settings.provider.js
42–45
info
useNewTabPageRebranding() hook is exported but not yet consumed by components in this PR. Infrastructure-only; no runtime UI impact until follow-up PRs gate styles/assets behind it.
app/index.js
179
info
body[data-rebrand] follows the existing data-platform-name / data-display / data-animation pattern. Attribute is set synchronously in installGlobalSideEffects() after init — consistent with other global side effects.
No changes to captured-globals.js, message bridge, messaging transports, postMessage, or origin validation. Special-pages run in a first-party embedded context with native-provided settings — outside the hostile third-party page threat model.
messages/types/settings.json
30–39
info
newTabPageRebranding schema lacks additionalProperties: false (same as adBlocking). Low risk because withFeatureState() only accepts state: 'enabled' | 'disabled' and ignores unknown keys via object spread.
app/settings.js
21, 49–61
info
Default state: 'disabled' and enum validation in withFeatureState() provide safe defaults when native omits the setting.
app/index.js
70, 179
info
Setting is read from native initial-setup response only; no new notify()/request() schemas and no nativeData forwarding risk.
Positive: Feature flag is config-gated with safe default-off behavior, matching the adBlocking pattern.
Risk Level
Low Risk — Special-pages-only settings/schema wiring with default-off feature flag, no injected runtime changes, and no security-boundary modifications.
Recommendations
Coordinate native rollout — Platforms must include newTabPageRebranding in initialSetup settings before consumers can enable rebrand UI in follow-up PRs.
(Optional) Add additionalProperties: false to the newTabPageRebranding schema object for consistency with stricter message schemas elsewhere.
Follow-up PRs should gate rebrand CSS/assets behind body[data-rebrand="true"] or useNewTabPageRebranding() to keep the flag remotely controllable per platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver-minorNew feature — triggers minor version bump
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
the
semver-minor
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
vkraucunas
left a comment
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1216270925937865?focus=true
TD:
Related PRs:
Description
Adds NTP rebrand flag wiring to the New Tab Page settings contract.
This introduces
settings.newTabPageRebranding, defaults it to disabled when absent, allows it throughwithFeatureState, exposesuseNewTabPageRebranding(), and setsdocument.body.dataset.rebrandfor CSS gating. Also adds?rebrand=enabledmock support and integration coverage for the body data attribute.Testing Steps
npm run serveChecklist
Please tick all that apply:
Note
Low Risk
Flag plumbing and a body data attribute only; no user-visible rebrand UI yet and behavior stays off unless native config or mock enables it.
Overview
Adds config-driven wiring for a New Tab Page rebrand rollout:
newTabPageRebrandingis part of theinitialSetupsettings contract (JSON schema + generated types), merged viaSettings/withFeatureStatewith a disabled default, and surfaced asuseNewTabPageRebranding().On init, the flag sets
body[data-rebrand]to"true"or"false"so future rebrand CSS can gate onbody[data-rebrand="true"](placeholder rule added inApp.module.css). Mock/dev flows support?rebrand=enabled, and Playwright tests assert the body attribute default and when the mock param is on.Reviewed by Cursor Bugbot for commit 2255ab0. Bugbot is set up for automated code reviews on this repo. Configure here.