build(deps-dev): bump prettier to 3.9.1 with formatting fixes - #2859
build(deps-dev): bump prettier to 3.9.1 with formatting fixes#2859cursor[bot] wants to merge 4 commits into
Conversation
Build Branch
Static preview entry points
QR codes (mobile preview)
Integration commandsnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/cursor/dependency-update-risk-review-407d")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-risk-review-407d
git -C submodules/content-scope-scripts checkout origin/pr-releases/cursor/dependency-update-risk-review-407dPin to exact commitnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "abb8e848efb1562ddd9d3099133c25c5443ccb18")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-risk-review-407d
git -C submodules/content-scope-scripts checkout abb8e848efb1562ddd9d3099133c25c5443ccb18 |
[Beta] Generated file diffTime updated: Mon, 20 Jul 2026 11:13:58 GMT |
There was a problem hiding this comment.
Stale comment
Injected PR Evaluation: Web Compatibility & Security
PR: build(deps-dev): bump prettier to 3.9.1 with formatting fixes (
012a337)
Web Compatibility Assessment
No findings.
This PR touches no
injected/code and makes no browser API overrides, DOM manipulation, or runtime behavioral changes. The only source edits outside lockfiles are Prettier-driven formatting:
special-pages/pages/new-tab/app/activity/NormalizeDataProvider.js(line ~240): adds a trailing semicolon after a ternary expression — semantically identical.special-pages/pages/new-tab/app/components/BackgroundProvider.js(line ~186): same pattern.special-pages/pages/new-tab/types/new-tab.ts(line ~11): collapses a multi-line union type to one line — type-only, no runtime effect.Special-pages run in embedded first-party UI (New Tab Page), not in arbitrary third-party page contexts, so these cosmetic edits carry no web-compat surface risk.
Security Assessment
No findings.
- Prettier 3.9.1 is a
devDependency; it runs only inlint/lint-fixand does not ship to end-user browsers.messaging/lib/shared-types.ts(lines 16, 22, 29): parentheses added around conditional-type generic constraints — compile-time TypeScript only; this file is referenced via JSDoc imports and emits no runtime code. No messaging transport, origin validation, or trust-boundary logic is modified.- No changes to
captured-globals.js, message bridge,shouldExemptMethod(), or any security-sensitive paths.
Risk Level
Low Risk — dev-tooling version bump with Prettier formatting fallout; zero injected-runtime or messaging-transport changes.
Recommendations
None required. Safe to merge from a web-compat and security perspective.
Sent by Cursor Automation: Web compat and sec
|
@claude please review |
There was a problem hiding this comment.
Stale comment
Web Compatibility Assessment
No findings.
This PR touches only dev tooling (
package.json,package-lock.json) and cosmetic formatting inmessaging/lib/shared-types.tsandspecial-pages/. No files underinjected/are modified. The formatting changes (trailing semicolons after ternaries, union-type layout, parentheses around conditional-type generic constraints) are syntactically equivalent and do not alter runtime behavior on any platform.
Security Assessment
No findings.
Prettier is a build-time formatter used in
lint/lint-fixscripts and does not ship to end-user browsers. Themessaging/lib/shared-types.tsedits affect compile-time TypeScript interfaces only — no messaging transport, bridge security, ornativeDatahandling changes.
Risk Level
Low Risk — devDependency bump (3.8.4 → 3.9.4) plus Prettier-driven formatting fallout; no injected runtime code, API overrides, or security-sensitive path changes.
Recommendations
- Info: Latest commit (
ec63f6f8b) bumps Prettier from 3.9.1 to 3.9.4 to align with Dependabot #2863. Assessment unchanged — still dev-only, no runtime impact.- Info: After merge, consider closing or rebasing #2858 (3.9.1-only bump) and #2863 (3.9.4 bump) to avoid duplicate dependency-update PRs.
- Info:
npx prettier . --checkpassing with 3.9.4 (per commit message) is sufficient validation for this PR.
Automated injected PR evaluation — web compatibility & security specialist
Sent by Cursor Automation: Web compat and sec
Bumps [prettier](https://github.com/prettier/prettier) from 3.8.4 to 3.9.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@3.8.4...3.9.1) --- updated-dependencies: - dependency-name: prettier dependency-version: 3.9.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…anges Prettier 3.9.0 changes TypeScript conditional-type extends formatting and ternary semicolon handling. Three files fail `prettier --check` after the bump without these updates.
json-schema-to-typescript formats generated types with the workspace Prettier version. The 3.9.0 TypeScript union formatting change updates BackgroundVariant output and fixes test-clean-tree / snapshots CI.
Align formatting companion PR with Dependabot #2863 (3.8.4 → 3.9.4). Verified npx prettier . --check passes with 3.9.4.
ec63f6f to
239754b
Compare
There was a problem hiding this comment.
Web Compatibility Assessment
No findings. This PR touches no injected/ code and makes no runtime behavioral changes.
| File | Severity | Notes |
|---|---|---|
package.json / package-lock.json |
info | Prettier 3.8.4 → 3.9.4 devDependency bump. Prettier runs only in lint/lint-fix CI scripts; it does not ship to end-user browsers. |
messaging/lib/shared-types.ts |
info | Prettier adds parentheses around conditional-type generic constraints (e.g. Method extends (T['notifications'] extends … ? … : never)). Compile-time TypeScript only; zero runtime effect on messaging transports or protocol. |
special-pages/pages/new-tab/app/activity/NormalizeDataProvider.js |
info | Trailing semicolon after ternary (: all;). Semantically identical to prior expression; no logic change. |
special-pages/pages/new-tab/app/components/BackgroundProvider.js |
info | Trailing semicolon after ternary (: states.loading;). Semantically identical; no logic change. |
special-pages/pages/new-tab/types/new-tab.ts |
info | Union type collapsed to single line by Prettier. Generated type layout only; no runtime impact. |
Special-pages run in embedded first-party contexts (NTP), not injected into arbitrary third-party pages. No API overrides, prototype mutations, DOM manipulation patterns, or platform entry-point changes.
Security Assessment
No findings.
| File | Severity | Notes |
|---|---|---|
| All changed files | info | No changes to captured-globals.js, message-bridge trust boundaries, origin validation, nativeData handling, postMessage usage, or config-gating logic. No new network requests, dynamic code execution, or data-exfiltration vectors introduced. |
Risk Level
Low Risk — devDependency version bump with Prettier-driven formatting fallout only; no injected runtime code, API shims, or security-sensitive path changes.
Recommendations
No action required for web compatibility or security. Optional housekeeping:
- info — Consider consolidating with #2863 (standalone Prettier
3.9.4bump) to avoid duplicate dependency PRs, since this PR now targets the same version. - info — Run
npx prettier . --checkin CI (already noted in commit message) to confirm the repo is fully formatted under 3.9.4.
Automated assessment (synchronize 239754bd). Assessment unchanged from prior run — final 3.9.4 alignment commit only.
Sent by Cursor Automation: Web compat and sec


Asana Task/Github Issue: Companion fix for #2858 (Dependabot prettier bump)
Description
Bumps
prettierfrom3.8.4to3.9.1and applies the formatting changes required by Prettier 3.9.0's JavaScript/TypeScript output updates.Without the formatting commit,
npm run lintfails because three files are reformatted by 3.9.1 but not updated:messaging/lib/shared-types.ts(conditional-typeextendsparentheses)special-pages/pages/new-tab/app/activity/NormalizeDataProvider.jsspecial-pages/pages/new-tab/app/components/BackgroundProvider.jsTesting Steps
npx prettier . --checkpassesnpx prettier@3.8.4 . --checkpasses onmain;npx prettier@3.9.1 . --checkfails before formatting fixes and passes afterChecklist