You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
macOS-only cosmetic change: border-radius from var(--sp-4) to var(--sp-6) under [data-platform-name="macos"]. No viewport, layout, or cross-platform DOM manipulation.
special-pages/shared/assets/img/icons/*.svg
all
info
Static SVG asset rebranding referenced as CSS background-image in Warning.module.css. No JavaScript execution, no page-derived content, no impact on third-party sites.
No warnings or errors identified.
Security Assessment
File
Lines
Severity
Finding
(all)
—
info
No changes to captured-globals.js, message bridge, messaging transports, postMessage, or config gating.
special-pages/shared/assets/img/icons/*.svg
all
info
Updated SVGs contain only static <path> elements with hardcoded fill colors. No <script>, event handlers, foreignObject, or external xlink:href references.
(all)
—
info
Special error pages are first-party embedded UIs with native messaging; they are not injected into hostile third-party page contexts.
No warnings, errors, or critical findings identified.
Risk Level
Low Risk — Visual-only special-pages changes (CSS border-radius + static SVG icons) with zero injected runtime surface area.
Recommendations
No action required for web compatibility or security from an injected-code perspective.
(info) PR title references "metrics" but the diff contains only UX/visual assets — consider aligning the title/description with actual scope for reviewer clarity.
(optional) Run special-error screenshot/integration tests if available to confirm the rebranded icons render correctly on macOS at the new border radius.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Injected PR Evaluation: Web Compatibility & Security
Re-assessed on synchronize (d3994f09). Scope unchanged: 22 files, all under special-pages/ — no injected/, messaging/, or runtime JavaScript changes.
Web Compatibility Assessment
File
Lines
Severity
Finding
(none)
—
—
No web compatibility concerns. Changes are confined to first-party special error page styling and static assets. This code does not inject into third-party pages and does not override browser APIs.
macOS-only border-radius change (--sp-4 → --sp-6) inside [data-platform-name="macos"]. Scoped to the embedded error-page container; no impact on third-party site layout or responsive behavior.
special-pages/shared/assets/img/icons/*.svg
all
info
Rebranded static SVG icons (path/fill updates only). Referenced as CSS background-image in Warning.module.css — no inline SVG DOM, no scripting surface. Screenshot baselines updated accordingly.
Security Assessment
File
Lines
Severity
Finding
(none)
—
—
No security concerns. No messaging, bridge, config, or network code touched.
SVGs contain only <path> elements with static fill colors. Verified: no <script>, event handlers, foreignObject, xlink:href, or external resource references. Safe for use as bundled static assets.
PR title ("Rebranding Metrics")
—
info
Title references metrics, but the diff contains no analytics, telemetry, or notify() calls. Visual-only change; no data-exfiltration surface introduced.
Risk Level
Low Risk — Cosmetic rebranding of a first-party embedded page (CSS border-radius + static SVG icons + screenshot baselines). Zero changes to injected content-scope features, API shims, messaging transports, or captured globals.
Recommendations
No action required for web compatibility or security.
Optional (non-blocking):
Consider aligning the PR title with the actual diff scope (visual rebranding only) to avoid confusion during review.
Verify macOS visual QA on-device — the border-radius and icon palette changes are intentional design updates reflected in updated Playwright screenshots.
The reason will be displayed to describe this comment to others. Learn more.
Web Compatibility Assessment
special-pages/pages/special-error/app/components/App.module.css (L52) — info: macOS-only container border-radius changed from var(--sp-4) to var(--sp-6). Cosmetic layout change scoped to [data-platform-name="macos"]. No third-party page impact.
special-pages/shared/assets/img/icons/Malware-Site-{96,128}.svg, Shield-Alert-96.svg — info: Rebranded static SVG icons (path fills only). Referenced as CSS background-image in Warning.module.css; no runtime DOM injection or API interaction.
special-pages/pages/special-error/integration-tests/.../*.png (18 files) — info: Screenshot baseline updates reflecting icon and border-radius changes. Expected test maintenance; no runtime behavior change.
No changes under injected/, messaging/, wrapper-utils.js, or platform entry points. This PR does not touch browser API overrides, prototype chains, or third-party script interaction.
Security Assessment
Scope — info: All changes are confined to special-pages/ (first-party embedded error pages). Code is not injected into arbitrary third-party web pages.
Malware-Site-{96,128}.svg, Shield-Alert-96.svg — info: SVGs contain only <path> elements with static fill attributes. No <script>, event handlers, foreignObject, external href/xlink:href, or dynamic content. Loaded via CSS background-image, not inline from page-controlled input.
Messaging / trust boundary — info: No changes to notify/request schemas, message bridge, nativeData handling, or origin validation.
Global capture / API shims — info: No changes to captured-globals.js, DDGProxy, or exemption logic.
No security findings.
Risk Level
Low Risk — Visual-only special-pages rebranding (CSS token, static SVG assets, screenshot baselines) with zero injected-runtime or messaging surface changes.
Recommendations
None required for web compatibility or security.
Optional (info): PR title references "metrics" but the diff is visual-only; consider aligning title/description with actual scope if metrics land in a follow-up PR.
Optional (info): Icon changes affect all platforms via shared assets in Warning.module.css; screenshot updates across iOS/Windows are expected and correctly included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver-patchBug fix / internal — no release needed
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/72649045549333/task/1216050073824226?focus=true
Description
This PR updates the Special Error Pages, so that we match the latest Figma mockups:
Testing Steps
Checklist
Please tick all that apply:
Note
Low Risk
Cosmetic CSS and static SVG swaps on user-visible error pages; no logic or security behavior changes.
Overview
Aligns Special Error Pages with the latest Figma mocks for macOS rebranding.
On macOS, the error dialog container corner radius increases from
--sp-4to--sp-6(24pt) inApp.module.css.Warning illustrations are replaced in place (same filenames, used by
Warning.module.cssfor SSL vs phishing/malware/scam):Malware-Site-96.svgandMalware-Site-128.svg: old gray browser + red alert artwork → new purple malware-themed artwork.Shield-Alert-96.svg: old shield graphic → updated shield with red alert badge styling.No routing, copy, or behavior changes—visual assets and one CSS token only.
Reviewed by Cursor Bugbot for commit e0490fe. Bugbot is set up for automated code reviews on this repo. Configure here.