You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Align shell spacing, Theme/Background/Sections, Windows switches, and footer gap with Desktop Components while keeping FF-off unchanged.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Injected PR Evaluation: Web Compatibility & Security
PR: NTP: Restyle Customize drawer behind rebrand flag (c5b51e53) Scope: 6 CSS files (+191 lines) in special-pages/ only. No injected/, messaging/, or runtime JavaScript changes.
Web Compatibility Assessment
File
Lines
Severity
Finding
All changed files
—
info
Changes are CSS-only in the embedded NTP special-page, not injected into third-party pages. Standard injected web-compat categories (API fidelity, prototype chain, DOM timing, platform API shims) do not apply.
All visual overrides are gated behind [data-rebrand="true"], driven by newTabPageRebranding (default disabled) → body[data-rebrand] in index.js. Legacy layout preserved when flag is off.
ntp-theme.css
44–47
info
Rebrand-only drawer width bump (256px → 264px for theme-variant drawers). Layout change is scoped to rebrand; no viewport <meta> manipulation.
Customizer.module.css
47
info
backdrop-filter: none on the customize button removes blur in rebrand mode — visual-only; no functional regression expected.
ThemeSection.module.css
121–131
info
macOS-only inset box-shadow on selected segmented-control segment — platform-scoped, rebrand-only.
Switch.module.css (shared)
100–110, 233–235
info
Windows medium switch sizing recolored under :global([data-rebrand="true"]). Only activates when an ancestor sets data-rebrand (currently NTP-only via installGlobalSideEffects). Onboarding/omnibar switches unaffected unless those pages adopt the same flag.
Customizer integration tests
—
info
Existing customizer.spec.js suite runs with rebrand off by default. No rebrand-on visual/integration coverage for drawer restyle.
No warnings or errors identified.
Security Assessment
File
Lines
Severity
Finding
All changed files
—
info
No changes to captured-globals.js, message bridge, messaging transports, postMessage, config parsing, or load()-time code.
All changed files
—
info
CSS uses static design-token variables only — no page-derived values interpolated into styles, no url() with user data, no dynamic code execution.
All changed files
—
info
Feature is remotely disableable via existing newTabPageRebranding setting; no new un-gated functionality.
No warnings, errors, or critical findings identified.
Risk Level
Low Risk — CSS-only NTP customizer restyle behind an existing remote-config feature flag; no injected runtime, API overrides, or messaging surface changes.
Recommendations
(info) Manually QA the Customize drawer with newTabPageRebranding enabled on Windows, macOS, iOS, and Android — especially drawer width, background-panel selection ring (::after pseudo-element), and Windows medium switches in VisibilityMenu.
(info) Consider a lightweight integration test opening the customizer with rebrand: 'enabled' mock param (pattern from new-tab.spec.js) to guard against accidental selector regressions.
(info) If other special-pages adopt data-rebrand in future, the shared Switch.module.css Windows-medium overrides will apply there too — document or scope further if that becomes a concern.
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Injected PR Evaluation: Web Compatibility & Security
PR: NTP: Restyle Customize drawer behind rebrand flag (c103d9f4) Scope: 6 CSS files + design-tokens bump (v0.30.0 → v0.33.0) in special-pages/ only. No injected/, messaging/, or runtime JavaScript changes.
Re-assessed after synchronize; latest commit adds design-tokens bump and space-token refactors.
Web Compatibility Assessment
File
Lines
Severity
Finding
All changed files
—
info
CSS-only changes in the embedded NTP special-page, not injected into third-party pages. Standard injected web-compat categories (API fidelity, prototype chain, DOM timing, platform API shims) do not apply.
Visual overrides gated behind [data-rebrand="true"], driven by newTabPageRebranding (default disabled) → body[data-rebrand] in index.js. Legacy layout preserved when flag is off.
ntp-theme.css
44–47
info
Rebrand-only drawer width bump (256px → 264px for theme-variant drawers). Layout change scoped to rebrand; no viewport <meta> manipulation.
Customizer.module.css
47
info
backdrop-filter: none on the customize button removes blur in rebrand mode — visual-only.
ThemeSection.module.css
121–131
info
macOS-only inset box-shadow on selected segmented-control segment — platform-scoped, rebrand-only.
ThemeSection.module.css
141–142
info
.variantButton selection-ring vars moved from hard-coded 2px to var(--ds-space-x-5)outside the rebrand block, so legacy UI is affected too. Value is equivalent (--ds-space-x-5: 2px in v0.33.0) — refactor only, not a visual regression.
Switch.module.css (shared)
100–110, 233–235
info
Windows medium switch sizing recolored under :global([data-rebrand="true"]). Only activates when an ancestor sets data-rebrand (currently NTP-only). Onboarding/omnibar switches unaffected unless those pages adopt the flag.
package.json / package-lock.json
31
warning
design-tokens v0.30.0 → v0.33.0 removes --ds-color-palette-* tokens. onboarding/.../ComparisonTable.module.css:119 still references --ds-color-palette-red-50 — unrelated to this PR's CSS but now unresolved at build time (CSS silently drops). Consider fixing in a companion PR or rebasing onto a palette-token migration.
Customizer integration tests
—
info
Existing customizer.spec.js suite runs with rebrand off by default. No rebrand-on visual/integration coverage for drawer restyle.
No errors identified.
Security Assessment
File
Lines
Severity
Finding
All changed files
—
info
No changes to captured-globals.js, message bridge, messaging transports, postMessage, config parsing, or load()-time code.
All changed files
—
info
CSS uses static design-token variables only — no page-derived values interpolated into styles, no url() with user data, no dynamic code execution.
All changed files
—
info
Feature is remotely disableable via existing newTabPageRebranding setting; no new un-gated functionality.
package.json
31
info
design-tokens is a devDependency used at build time for CSS token resolution — no runtime injection surface.
No warnings, errors, or critical findings identified.
Risk Level
Low Risk — CSS-only NTP customizer restyle behind an existing remote-config feature flag, plus a devDependency token bump; no injected runtime, API overrides, or messaging surface changes.
Recommendations
(warning) Address the removed --ds-color-palette-red-50 reference in ComparisonTable.module.css before or alongside the design-tokens v0.33.0 bump (migrate to a theme token or local variable).
(info) Manually QA the Customize drawer with newTabPageRebranding enabled on Windows, macOS, iOS, and Android — especially drawer width, background-panel selection ring (::after pseudo-element), and Windows medium switches in VisibilityMenu.
(info) Consider a lightweight integration test opening the customizer with rebrand: 'enabled' mock param (pattern from new-tab.spec.js) to guard against accidental selector regressions.
(info) If other special-pages adopt data-rebrand in future, the shared Switch.module.css Windows-medium overrides will apply there too — document or scope further if that becomes a concern.
The reason will be displayed to describe this comment to others. Learn more.
Non-gated token change affects all users' selection ring
Low Severity
The --selection-ring-offset and --selection-ring-width in the base .variantButton rule are changed from hardcoded 2px to var(--ds-space-x-5) without being gated behind [data-rebrand="true"]. This affects non-rebrand users. The equivalent change in CustomizerDrawerInner.module.css (line 312-313) is properly inside a [data-rebrand="true"] block. If --ds-space-x-5 is undefined or resolves to a value other than 2px, the theme variant selection ring breaks for all users. A fallback like var(--ds-space-x-5, 2px) would make this safe regardless of token availability.
The reason will be displayed to describe this comment to others. Learn more.
Injected PR Evaluation: Web Compatibility & Security
PR: NTP: Restyle Customize drawer behind rebrand flag (3da8c5ef) Scope: 7 CSS files + design-tokens bump (v0.30.0 → v0.33.0) in special-pages/ only. No injected/, messaging/, or runtime JavaScript changes.
Re-assessed after synchronize; latest commit 3da8c5ef hardcodes the DDG icon color in onboarding after palette-token removal.
Web Compatibility Assessment
File
Lines
Severity
Finding
All changed files
—
info
CSS-only changes in the embedded NTP special-page, not injected into third-party pages. Standard injected web-compat categories (API fidelity, prototype chain, DOM timing, platform API shims) do not apply.
Visual overrides gated behind [data-rebrand="true"], driven by newTabPageRebranding (default disabled) → body[data-rebrand] in index.js. Legacy layout preserved when flag is off.
ntp-theme.css
44–47
info
Rebrand-only drawer width bump (256px → 264px for theme-variant drawers). Layout change scoped to rebrand; no viewport <meta> manipulation.
Customizer.module.css
47
info
backdrop-filter: none on the customize button removes blur in rebrand mode — visual-only.
ThemeSection.module.css
121–131
info
macOS-only inset box-shadow on selected segmented-control segment — platform-scoped, rebrand-only.
ThemeSection.module.css
141–142
info
.variantButton selection-ring vars moved from hard-coded 2px to var(--ds-space-x-5)outside the rebrand block, so legacy UI is affected too. Value is equivalent (--ds-space-x-5: 2px in v0.33.0) — refactor only, not a visual regression.
Switch.module.css (shared)
100–110, 233–235
info
Windows medium switch sizing recolored under :global([data-rebrand="true"]). Only activates when an ancestor sets data-rebrand (currently NTP-only).
ComparisonTable.module.css
118–122
info
Collateral design-tokens bump: --ds-color-palette-red-50 replaced with hardcoded #de5833 and explanatory comment. Restores onboarding DDG icon background after palette removal in v0.31+.
Customizer integration tests
—
info
Existing customizer.spec.js suite runs with rebrand off by default. No rebrand-on visual/integration coverage for drawer restyle.
No errors identified.
Security Assessment
File
Lines
Severity
Finding
All changed files
—
info
No changes to captured-globals.js, message bridge, messaging transports, postMessage, config parsing, or load()-time code.
All changed files
—
info
CSS uses static design-token variables and a hardcoded hex color — no page-derived values interpolated into styles, no url() with user data, no dynamic code execution.
All changed files
—
info
Feature is remotely disableable via existing newTabPageRebranding setting; no new un-gated functionality.
package.json
31
info
design-tokens is a devDependency used at build time for CSS token resolution — no runtime injection surface.
No warnings, errors, or critical findings identified.
Risk Level
Low Risk — CSS-only NTP customizer restyle behind an existing remote-config feature flag, plus a devDependency token bump with collateral onboarding fix; no injected runtime, API overrides, or messaging surface changes.
Recommendations
(info) Manually QA the Customize drawer with newTabPageRebranding enabled on Windows, macOS, iOS, and Android — especially drawer width, background-panel selection ring (::after pseudo-element), and Windows medium switches in VisibilityMenu.
(info) Consider a lightweight integration test opening the customizer with rebrand: 'enabled' mock param (pattern from new-tab.spec.js) to guard against accidental selector regressions.
(info) If other special-pages adopt data-rebrand in future, the shared Switch.module.css Windows-medium overrides will apply there too — document or scope further if that becomes a concern.
The reason will be displayed to describe this comment to others. Learn more.
resolved: Prior warning about unresolved --ds-color-palette-red-50 after the design-tokens v0.33.0 bump is addressed here. Hardcoded #de5833 with an explanatory comment is appropriate given no equivalent theme token exists in the desktop-browsers build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver-minorNew feature — triggers minor version bump
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
github-actions
Bot
added
the
semver-minor
Asana Task/Github Issue:
Description
Restyle the New Tab Customize button and drawer (shell, Theme segmented control, Background tiles, Sections rows + Windows switches, footer spacing) to match Desktop Components, gated behind
newTabPageRebranding/body[data-rebrand="true"]. FF-off styles remain unchanged.Testing Steps
?rebrand=enabled&autoOpen=true&themeVariant=default&platform=windowsand confirm Windows switch size/thumb + Customize button fill states?rebrand=disabled(or omit rebrand) keeps the previous Customize button/drawer lookChecklist
Please tick all that apply:
Made with Cursor