fix(onboarding): replace removed design-tokens palette variable - #2904
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(onboarding): replace removed design-tokens palette variable#2904cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
v0.31.0 removes --ds-color-palette-* tokens from desktop-browsers tokens.css. Use the DDG brand color directly in v4 ComparisonTable, matching the v3 implementation.
Contributor
Build Branch
Static preview entry points
QR codes (mobile preview)
Integration commandsnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/cursor/dependency-update-risk-review-4156")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-risk-review-4156
git -C submodules/content-scope-scripts checkout origin/pr-releases/cursor/dependency-update-risk-review-4156Pin to exact commitnpm (Android / Extension): Swift Package Manager (Apple): .package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "3922210834795668de1ba5c2aa9f7473ccece2ad")git submodule (Windows): git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/dependency-update-risk-review-4156
git -C submodules/content-scope-scripts checkout 3922210834795668de1ba5c2aa9f7473ccece2ad |
Contributor
[Beta] Generated file diffTime updated: Fri, 24 Jul 2026 11:03:24 GMT AppleFile has changed IntegrationFile has changed WindowsFile has changed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: Companion fix for #2902
Description
@duckduckgo/design-tokensv0.31.0 removes all--ds-color-palette-*tokens frombuild/desktop-browsers/tokens.css(see duckduckgo/design-tokens#31). Onboarding v4'sComparisonTablestill referenced--ds-color-palette-red-50for the DuckDuckGo browser icon background, which would render as transparent after the bump.Replace the removed token with the DDG brand color
#de5833, matching the existing v3ComparisonTableimplementation.Testing Steps
makeDefaultSinglestep and confirm the DuckDuckGo icon retains its orange backgroundnpm run test.screenshots -- pages/onboarding/integration-tests/onboarding.screenshots.spec.js --project onboarding-screenshots-macos-light --grep v4-3-makeDefaultSingleChecklist
Please tick all that apply: