Skip to content

test: add regression coverage for customize responses, history icons, and error handlers - #2908

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/regression-test-coverage-automation-b1b2
Draft

test: add regression coverage for customize responses, history icons, and error handlers#2908
cursor[bot] wants to merge 2 commits into
mainfrom
cursor/regression-test-coverage-automation-b1b2

Conversation

@cursor

@cursor cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Adds regression integration tests for recently merged special-pages behavior that shipped without adequate coverage.

Risky behavior now covered

  1. NTP Customize Responses Tools menu (Add Customize Responses to NTP omnibar Tools menu #2865) — config gating, backend sublabel, native omnibar_openCustomizeResponses / omnibar_setCustomizeResponsesActive notifications, apply toggle, collapsed tools trigger when customization is active, and disabled state during image-generation mode.
  2. History macOS rebranding icons (History: Updates Icons on macOS #2886) — platform-specific sidebar icon map selection (rebrandingIconMap vs iconMap).
  3. Global error listeners (history + new-tab) — parity with onboarding for cross-origin ErrorEvent fallbacks, non-Error throws, and primitive/nullish rejection reasons.
  4. NTP attachmentLimits.images.maxPerTurn (NTP: Use attachmentLimits config for NTP omnibar attachments #2816) — backend-configured per-turn image cap enforcement.

Test files added/updated

  • special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.spec.js
  • special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar.page.js
  • special-pages/pages/new-tab/app/omnibar/integration-tests/omnibar-attachments.spec.js
  • special-pages/pages/history/integration-tests/history.spec.js
  • special-pages/pages/history/integration-tests/history.page.js
  • special-pages/pages/new-tab/integration-tests/new-tab.spec.js

Why these tests materially reduce regression risk

  • Customize Responses is user-facing AI chat configuration wired through multiple config flags and native notifications; a regression could silently break customization or send wrong native messages.
  • History icon selection is a simple platform branch easy to break during rebranding work.
  • Error-handler edge cases affect crash reporting fidelity in production.
  • imageMaxPerTurn is a server-driven limit; hardcoding assumptions in tests would miss backend contract changes.

Testing Steps

cd special-pages
npm run test-int -- --project integration --grep "AI chat customize responses|sidebar icons|global error listeners|image cap follows" --reporter list

All 25 new/updated tests pass on the integration project.

Checklist

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged
Open in Web View Automation 

… and error handlers

- Add omnibar Customize Responses tools-menu integration tests (#2865)
- Add History macOS rebranding icon selection tests (#2886)
- Add error-handler parity tests for history and new-tab (onboarding pattern)
- Add imageMaxPerTurn attachmentLimits config test (#2816)
@github-actions

Copy link
Copy Markdown
Contributor

Build Branch

Branch pr-releases/cursor/regression-test-coverage-automation-b1b2
Commit 8de09a2203
Updated July 27, 2026 at 8:07:57 AM UTC

Static preview entry points

QR codes (mobile preview)
Entry point QR code
Docs QR for docs preview
Static pages QR for static pages preview
Integration pages QR for integration pages preview

Integration commands

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#pr-releases/cursor/regression-test-coverage-automation-b1b2

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", branch: "pr-releases/cursor/regression-test-coverage-automation-b1b2")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/regression-test-coverage-automation-b1b2
git -C submodules/content-scope-scripts checkout origin/pr-releases/cursor/regression-test-coverage-automation-b1b2
Pin to exact commit

npm (Android / Extension):

npm i github:duckduckgo/content-scope-scripts#8de09a22030a6283b2e7bfca727ab933b9ba0b5a

Swift Package Manager (Apple):

.package(url: "https://github.com/duckduckgo/content-scope-scripts.git", revision: "8de09a22030a6283b2e7bfca727ab933b9ba0b5a")

git submodule (Windows):

git -C submodules/content-scope-scripts fetch origin pr-releases/cursor/regression-test-coverage-automation-b1b2
git -C submodules/content-scope-scripts checkout 8de09a22030a6283b2e7bfca727ab933b9ba0b5a

@github-actions github-actions Bot added the semver-patch Bug fix / internal — no release needed label Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

[Beta] Generated file diff

Time updated: Mon, 27 Jul 2026 08:08:56 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Bug fix / internal — no release needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant