You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Gates omnibar rebrand styles behind newTabPageRebranding (body[data-rebrand="true"]): 24px radius, new rest-state shadow/border, wider search-row padding, and a fully round close button. The 24px radius is kept in the focused/typing, attachment-limit-warning, and suggestions-open states so it doesn't shrink back down to the legacy 15px while the omnibar is active.
Testing Steps
Open NTP with ?rebrand=enabled → omnibar pill has 24px corners, updated rest-state shadow, wider left padding on the search row, and a round close (X) button
Focus the input / open suggestions / trigger the attachment-limit warning → radius stays 24px, not the legacy 15px
Same page with ?rebrand=disabled (or omit) → live/legacy omnibar styles, pixel-unchanged
Checklist
Please tick all that apply:
I have tested this change locally
I have tested this change locally in all supported browsers
This change will be visible to users
I have added automated tests that cover this change
Behind the rebrand flag: bump the omnibar's border-radius/box-shadow to the
new DS tokens, keep that radius when focused/typing/suggestions-open, widen
the search row's padding, and make the close button fully round.
Co-authored-by: Cursor <cursoragent@cursor.com>
borgateo
changed the title
(feat)rebrand: NTP - Omnibar radius, shadow, and padding
(feat)rebrand: NTP - Omnibar rebrand
Jul 28, 2026
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Web Compatibility & Security Review
Scope: 2 files changed — Omnibar.module.css and SearchForm.module.css (special-pages NTP omnibar rebrand CSS only). No injected/ changes.
Web Compatibility Assessment
File
Lines
Severity
Finding
Omnibar.module.css
164–178
info
Rebrand rules are correctly gated behind :global(body[data-rebrand="true"]), matching the established NTP rebrand pattern (index.js sets body.dataset.rebrand from native settings). With the flag off, omnibar rendering is unchanged.
Omnibar.module.css
173–176
info
Reuses existing :has() selectors already present in base rules (lines 83–133). Acceptable for embedded NTP WebViews; no third-party page impact.
Omnibar.module.css
167–169
warning
Uses --ds-radius-x06, which is not defined in @duckduckgo/design-tokens v0.30.0 (current special-pages/package.json). border-radius will be ignored when rebrand is enabled until design-tokens is bumped (other rebrand PRs use v0.33.0).
SearchForm.module.css
106–114
warning
Uses --ds-space-x05 and --ds-radius-full, also absent from design-tokens v0.30.0. Rebrand padding/radius on the input row and close button will not apply.
SearchForm.module.css
106, 110
info
Hardcoded 7px vertical padding (not a design token). Acceptable short-term but harder to keep in sync if spacing scale changes.
Security Assessment
No findings. Changes are presentational CSS in the privileged NTP embedded page. No messaging, API overrides, captured-globals, DOM injection from page-controlled data, postMessage, or config-trust boundary changes.
Risk Level
Low Risk — special-pages-only CSS scoped behind the data-rebrand feature flag; no injected runtime or security-sensitive code paths touched.
Recommendations
(warning) Bump @duckduckgo/design-tokens to a version that defines --ds-radius-x06, --ds-space-x05, and --ds-radius-full (v0.33.0 per sibling rebrand PRs), or add a companion PR before merge.
(info) Consider a rebrand-on screenshot test for the omnibar rest/focused states once tokens resolve.
(info) Verify visually on Windows/iOS that the 7px padding keeps suffix-spacer text aligned (the inline comment documents the constraint well).
The reason will be displayed to describe this comment to others. Learn more.
Rebrand outline: none loses to dark theme specificity
Medium Severity
The rebrand rest-state rule sets outline: none on .popup with specificity (0, 2, 1) (body[data-rebrand="true"] .popup). However, the existing dark-mode nested rule at lines 64–69 ([data-background-kind="color"] [data-theme="dark"] .popup) has specificity (0, 3, 0), which wins. In dark mode with color or gradient backgrounds, the old outline: 1px solid rgba(0, 0, 0, 0.12) persists alongside the new box-shadow border (0 0 0 1px …), producing a double-border effect.
Consolidate the duplicated border-radius into a local custom property,
align data-rebrand quoting/comments with the rest of the codebase, and
use --ds-space-* tokens consistently instead of mixing in legacy --sp-*.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Web Compatibility & Security Review
Scope: 2 files changed — Omnibar.module.css and SearchForm.module.css (special-pages NTP omnibar rebrand CSS only). No injected/ changes.
Delta since last review (1563d0de): Omnibar rebrand CSS consolidated via --omnibar-radius; SearchForm padding now uses --ds-space-x01 / --ds-space-x08 instead of the locally-defined --sp-1 / --sp-8.
Web Compatibility Assessment
File
Lines
Severity
Finding
Omnibar.module.css
164–179
info
Rebrand rules correctly gated behind :global(body[data-rebrand="true"]), matching the established NTP pattern (index.js sets body.dataset.rebrand from native settings). With the flag off, omnibar rendering is unchanged.
Omnibar.module.css
168–172
info
Reuses existing :has() selectors already present in base rules (lines 83–133). Acceptable for embedded NTP WebViews; no third-party page impact.
Omnibar.module.css
165
warning
--ds-radius-x06 is not defined in @duckduckgo/design-tokens v0.30.0 (current special-pages/package.json). Rebrand border-radius will be ignored until design-tokens is bumped (sibling rebrand PRs use v0.33.0).
SearchForm.module.css
106–116
warning
--ds-space-x01, --ds-space-x05, --ds-space-x08, and --ds-radius-full are all absent from design-tokens v0.30.0. The latest commit replaced working local --sp-1 / --sp-8 tokens with undefined --ds-space-x* tokens, so rebrand padding and close-button radius will not apply even though the equivalent --sp-* values were available.
SearchForm.module.css
107, 111
info
Hardcoded 7px vertical padding (not a design token). Acceptable short-term; the inline comment correctly documents the suffix-spacer alignment constraint.
Security Assessment
No findings. Changes are presentational CSS in the privileged NTP embedded page. No messaging, API overrides, captured-globals, DOM injection from page-controlled data, postMessage, or config-trust boundary changes.
Risk Level
Low Risk — special-pages-only CSS scoped behind the data-rebrand feature flag; no injected runtime or security-sensitive code paths touched.
Recommendations
(warning) Bump @duckduckgo/design-tokens to a version defining --ds-radius-x06, --ds-space-x01, --ds-space-x05, --ds-space-x08, and --ds-radius-full (v0.33.0 per sibling rebrand PRs), or restore --sp-1 / --sp-8 until that bump lands.
(info) Consider a rebrand-on screenshot test for omnibar rest/focused states once tokens resolve.
(info) Verify visually on Windows/iOS that the 7px padding keeps suffix-spacer text aligned.
The reason will be displayed to describe this comment to others. Learn more.
This commit swaps locally-defined --sp-1 / --sp-8 (from shared/styles/variables.css) for --ds-space-x01 / --ds-space-x08, which are not present in design-tokens v0.30.0. Until the tokens package is bumped, the entire padding declaration is invalid at computed-value time and rebrand padding won't apply. Consider reverting to --sp-* here or bundling the design-tokens bump in this PR.
Behind the rebrand flag, .textarea and .buttons now use the same 20px
left inset as SearchForm's .input/.form, so text/icons stay aligned
when switching between the Search and Duck.ai omnibar tabs.
Co-authored-by: Cursor <cursoragent@cursor.com>
New rules reference --ds-space-x01, --ds-space-x05, --ds-space-x08, --ds-radius-x06, and --ds-radius-full. These tokens exist in design-tokens/build/static-pages/ but are not exported in desktop-browsers/tokens.css (v0.30.0) that shared/styles/design-tokens.css imports. Undefined custom properties invalidate the entire declaration at computed-value time, so rebrand padding/radius won't apply until the tokens package is bumped or spacing/radius tokens are wired into the NTP import chain. New in 0ae5480b:AiChatForm.module.css now uses --ds-space-x05 for the same reason.
Omnibar.module.css
176–178 vs 64–68
warning
Rebrand rest-state sets outline: none at specificity (0, 2, 1), but the existing dark-mode nested rule [data-background-kind="color"] [data-theme="dark"] .popup at lines 64–68 has specificity (0, 3, 0) and still applies outline: 1px solid rgba(0, 0, 0, 0.12). In dark mode with color/gradient backgrounds, the new box-shadow border (0 0 0 1px …) may stack with the legacy outline, producing a double-border effect.
SearchForm.module.css
108, 112
info
Hardcoded 7px vertical padding in rebrand rules while horizontal spacing uses design tokens. Consider tokenizing vertical padding for consistency once tokens are available.
Security Assessment
No findings. Changes are presentational CSS in the embedded NTP special-page. No messaging, nativeData, bridge, origin validation, prototype patching, or user-controlled value injection paths are touched.
Risk Level
Low Risk — Special-pages NTP omnibar CSS only; no injected runtime code; all visual changes are feature-flag gated.
Recommendations
(warning) Bundle a design-tokens bump (v0.33.0 as in sibling rebrand PRs) or revert to existing --sp-* equivalents (--sp-1/--sp-5/--sp-8) until spacing/radius tokens are available in the NTP import chain.
(warning) Fix dark-mode outline stacking — either nest the rebrand outline: none under the same [data-theme="dark"] selectors, or raise specificity to beat (0, 3, 0).
(info) Add a rebrand-on omnibar screenshot test once tokens are wired, to catch padding/radius/shadow regressions across Search and Duck.ai tabs.
The reason will be displayed to describe this comment to others. Learn more.
New in 0ae5480b: Duck.ai row left-padding alignment mirrors SearchForm, which is the right UX intent. Same caveat as the search row — --ds-space-x05 is not in desktop-browsers/tokens.css v0.30.0, so this padding-left declaration is invalid until spacing tokens are wired into the NTP import chain (or you revert to --sp-5, which is already 20px).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semver-minorNew feature — triggers minor version bump
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
borgateo
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
github-actions
Bot
added
the
semver-minor
Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1216270925937867?focus=true
Description
Gates omnibar rebrand styles behind
newTabPageRebranding(body[data-rebrand="true"]): 24px radius, new rest-state shadow/border, wider search-row padding, and a fully round close button. The 24px radius is kept in the focused/typing, attachment-limit-warning, and suggestions-open states so it doesn't shrink back down to the legacy 15px while the omnibar is active.Testing Steps
?rebrand=enabled→ omnibar pill has 24px corners, updated rest-state shadow, wider left padding on the search row, and a round close (X) button?rebrand=disabled(or omit) → live/legacy omnibar styles, pixel-unchangedChecklist
Please tick all that apply:
Made with Cursor