Danger repo name check fixes (#16)

* Fix color checks.

* Fix localization warning string.

Author: samsymons

org/allPRs.ts

@@ -86,12 +86,7 @@ export const localizedStrings = async () => {
         // * NSLocalizedString(
         // This way it will match `NSLocalizedString(` but not `NSLocalizedString` (without the opening parenthesis, which could be used in a comment).
         if (addedLines?.find(value => /\bNSLocalizedString\(/.test(value))) {
-            let instructions = "";
-            if (danger.github.thisPR.repo == "iOS") {
-                instructions = " See [Localization Guidelines](https://app.asana.com/0/0/1185863667140706/f) for more information.";
-            } else if (danger.github.thisPR.repo == "macos-browser") {
-                instructions = " See [Localization Guidelines](https://app.asana.com/0/0/1206727265537758/f) for more information.";
-            }
+            let instructions = " See [iOS](https://app.asana.com/0/0/1185863667140706/f) and [macOS](https://app.asana.com/0/0/1206727265537758/f) localization guidelines for more information.";
             message("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change." + instructions);
             break;
         }
@@ -108,9 +103,9 @@ export const licensedFonts = async () => {
 
 export const newColors = async () => {
     // Fail if new colors are added to the app (DesignResourcesKit)
-    if (danger.github.thisPR.repo == "iOS") {
+    if (danger.github.thisPR.repo == "apple-browsers") {
         const createdFiles = danger.git.created_files; 
-        if (createdFiles.some(path => path.match(/Assets.xcassets\/.*\.colorset/))) {
+        if (createdFiles.some(path => path.match(/iOS\/DuckDuckGo\/Assets.xcassets\/.*\.colorset/))) {
             fail("DesignResourcesKit: No new colors should be added to this app.")
         }
     }

tests/localizedStrings.allPRs.test.ts

@@ -84,7 +84,7 @@ describe("Localized Strings checks", () => {
 
         await localizedStrings()
 
-        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1185863667140706/f) for more information.")
+        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [iOS](https://app.asana.com/0/0/1185863667140706/f) and [macOS](https://app.asana.com/0/0/1206727265537758/f) localization guidelines for more information.")
     })
 
     it("messages with added code that contains NSLocalizedString call, including macOS Localization guidelines URL when run for macos-browser repo", async () => {
@@ -95,7 +95,7 @@ describe("Localized Strings checks", () => {
 
         await localizedStrings()
 
-        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1206727265537758/f) for more information.")
+        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [iOS](https://app.asana.com/0/0/1185863667140706/f) and [macOS](https://app.asana.com/0/0/1206727265537758/f) localization guidelines for more information.")
     })
 
     it("messages with UserText.swift-style added code, including iOS Localization guidelines URL when run for iOS repo", async () => {
@@ -106,7 +106,7 @@ describe("Localized Strings checks", () => {
 
         await localizedStrings()
 
-        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1185863667140706/f) for more information.")
+        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [iOS](https://app.asana.com/0/0/1185863667140706/f) and [macOS](https://app.asana.com/0/0/1206727265537758/f) localization guidelines for more information.")
     })
 
     it("messages with UserText.swift-style added code, including macOS Localization guidelines URL when run for macos-browser repo", async () => {
@@ -117,6 +117,6 @@ describe("Localized Strings checks", () => {
 
         await localizedStrings()
 
-        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [Localization Guidelines](https://app.asana.com/0/0/1206727265537758/f) for more information.")
+        expect(dm.message).toHaveBeenCalledWith("You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See [iOS](https://app.asana.com/0/0/1185863667140706/f) and [macOS](https://app.asana.com/0/0/1206727265537758/f) localization guidelines for more information.")
     })
 })

tests/newColors.allPRs.test.ts

@@ -10,13 +10,13 @@ beforeEach(() => {
 
     dm.danger = {
         git: {
-            modified_files: ["Core/AppConfigurationURLProvider.swift"],
+            modified_files: ["iOS/Core/AppConfigurationURLProvider.swift"],
             created_files: [],
             deleted_files: [],
         },
         github: {
             thisPR: {
-                repo: "iOS"
+                repo: "apple-browsers"
             }
         },
     };
@@ -32,24 +32,23 @@ describe("New colors checks", () => {
     })
 
     it("does not fail with changes to colorset files", async () => {
-        dm.danger.git.modified_files = ["DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json", "Core/AppConfigurationURLProvider.swift"]
+        dm.danger.git.modified_files = ["iOS/DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json", "iOS/Core/AppConfigurationURLProvider.swift"]
 
         await newColors()
 
         expect(dm.fail).not.toHaveBeenCalled()
     })
 
     it("fails with new colorset file", async () => {
-        dm.danger.git.created_files = ["DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json", "Core/AppConfigurationURLProvider.swift"]
+        dm.danger.git.created_files = ["iOS/DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json", "iOS/Core/AppConfigurationURLProvider.swift"]
 
         await newColors()
 
         expect(dm.fail).toHaveBeenCalledWith("DesignResourcesKit: No new colors should be added to this app.")
     })
 
-    it("does not fail in others repos than iOS", async () => {
-        dm.danger.github.thisPR.repo = "macos-browser"
-        dm.danger.git.created_files = ["DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json"]
+    it("does not fail in the macOS client", async () => {
+        dm.danger.git.created_files = ["macOS/DuckDuckGo/Assets.xcassets/SomeColor.colorset/Contents.json"]
 
         await newColors()