Skip to content

Add a check for adding singletons#17

Merged
ayoy merged 6 commits intomainfrom
dominik/singletons
May 12, 2025
Merged

Add a check for adding singletons#17
ayoy merged 6 commits intomainfrom
dominik/singletons

Conversation

@ayoy
Copy link
Copy Markdown
Contributor

@ayoy ayoy commented May 10, 2025

Task URL: https://app.asana.com/1/137249556945/project/1203301625297703/task/1210209652200970?focus=true

Description:
This change adds a new check that should fail when new singletons are defined in Swift code.
It checks for static let/var shared.

@ayoy ayoy force-pushed the dominik/singletons branch from ea83604 to a4b8634 Compare May 10, 2025 14:02
Comment thread org/allPRs.ts
@ayoy ayoy force-pushed the dominik/singletons branch from 77878cf to 590c62f Compare May 10, 2025 14:19
Comment thread tests/singletons.allPRs.test.ts Outdated
Copy link
Copy Markdown
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit 5104319 into main May 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants