Add a warning when adding a new parent feature flag#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/1/137249556945/project/1199333091098016/task/1212670452887355?focus=true
This PR adds a new check that warns when adding a new feature flag that uses a parent feature flag. The issue it warns about is that parent feature flags don't support rollouts, and if you want one then you should use a subfeature flag.
See duckduckgo/apple-browsers#3064 for an example of this working.
Note
Adds a Danger check to flag additions of parent feature flags and wires it into PR validation, with unit tests.
remoteReleasableFeatureWarninginorg/allPRs.tsto scan Swift diffs for added lines containing.remoteReleasable(.featureand issue awarnwith guidancetests/remoteReleasableFeatureWarning.allPRs.test.tscovering no Swift changes, no diff, deletions, and additionsWritten by Cursor Bugbot for commit ff45fb7. This will update automatically on new commits. Configure here.