Skip to content

Add a warning when adding a new parent feature flag#20

Merged
samsymons merged 1 commit intomainfrom
sam/remote-feature-flag-check
Jan 6, 2026
Merged

Add a warning when adding a new parent feature flag#20
samsymons merged 1 commit intomainfrom
sam/remote-feature-flag-check

Conversation

@samsymons
Copy link
Copy Markdown
Contributor

@samsymons samsymons commented Jan 6, 2026

Task: https://app.asana.com/1/137249556945/project/1199333091098016/task/1212670452887355?focus=true

This PR adds a new check that warns when adding a new feature flag that uses a parent feature flag. The issue it warns about is that parent feature flags don't support rollouts, and if you want one then you should use a subfeature flag.

See duckduckgo/apple-browsers#3064 for an example of this working.


Note

Adds a Danger check to flag additions of parent feature flags and wires it into PR validation, with unit tests.

  • Introduces remoteReleasableFeatureWarning in org/allPRs.ts to scan Swift diffs for added lines containing .remoteReleasable(.feature and issue a warn with guidance
  • Integrates the new check into the default Danger run
  • Adds tests in tests/remoteReleasableFeatureWarning.allPRs.test.ts covering no Swift changes, no diff, deletions, and additions

Written by Cursor Bugbot for commit ff45fb7. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@samsymons samsymons merged commit e6b3ebd into main Jan 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants