Add check for proper feature flag task comment for all PR's#21
Merged
Conversation
ayoy
approved these changes
Feb 19, 2026
Contributor
ayoy
left a comment
There was a problem hiding this comment.
LGTM, the tests are good 👍 I'd consider failing the check instead of showing a warning, since we want to enforce linking feature flags to Asana tasks.
Contributor
Author
Thanks! Reporting failure is the end goal, but I want to field-test it first for any false positives and not block work if I got it wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/1/137249556945/project/1211834678943996/task/1212001845756281?focus=true
Adds a warning when there’s no valid asana task reference for modified FeatureFlag case. Checks both macOS and iOS.
Test PR in apple-browsers repo: duckduckgo/apple-browsers#3632 (comment)
Note
Low Risk
Limited to CI/Danger warnings and new unit tests; no runtime app behavior changes, but diff-parsing heuristics could produce false positives/negatives.
Overview
Adds a new Danger check (
featureFlagAsanaLink) that scans diffs toiOS/Core/FeatureFlag.swiftandmacOS/.../FeatureFlag.swiftand warns when newly-addedcaseentries inenum FeatureFlaglack a valid/// https://app.asana.com/.../task/<id>comment (allowing optional query params) immediately above the added case.Updates the default Danger run to execute this check, and adds a comprehensive Jest test suite covering valid/invalid links, iOS vs macOS paths, enum-scope detection, brace tracking, and multi-case reporting.
Written by Cursor Bugbot for commit 8ce1323. This will update automatically on new commits. Configure here.