Skip to content

Add check for proper feature flag task comment for all PR's#21

Merged
dus7 merged 7 commits intomainfrom
mariusz/add-feature-flag-check
Feb 19, 2026
Merged

Add check for proper feature flag task comment for all PR's#21
dus7 merged 7 commits intomainfrom
mariusz/add-feature-flag-check

Conversation

@dus7
Copy link
Copy Markdown
Contributor

@dus7 dus7 commented Feb 18, 2026

Task: https://app.asana.com/1/137249556945/project/1211834678943996/task/1212001845756281?focus=true

Adds a warning when there’s no valid asana task reference for modified FeatureFlag case. Checks both macOS and iOS.

Test PR in apple-browsers repo: duckduckgo/apple-browsers#3632 (comment)


Note

Low Risk
Limited to CI/Danger warnings and new unit tests; no runtime app behavior changes, but diff-parsing heuristics could produce false positives/negatives.

Overview
Adds a new Danger check (featureFlagAsanaLink) that scans diffs to iOS/Core/FeatureFlag.swift and macOS/.../FeatureFlag.swift and warns when newly-added case entries in enum FeatureFlag lack a valid /// https://app.asana.com/.../task/<id> comment (allowing optional query params) immediately above the added case.

Updates the default Danger run to execute this check, and adds a comprehensive Jest test suite covering valid/invalid links, iOS vs macOS paths, enum-scope detection, brace tracking, and multi-case reporting.

Written by Cursor Bugbot for commit 8ce1323. This will update automatically on new commits. Configure here.

Comment thread org/allPRs.ts Outdated
Comment thread org/allPRs.ts Outdated
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@duckduckgo duckduckgo deleted a comment from cursor bot Feb 19, 2026
Copy link
Copy Markdown
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tests are good 👍 I'd consider failing the check instead of showing a warning, since we want to enforce linking feature flags to Asana tasks.

@dus7
Copy link
Copy Markdown
Contributor Author

dus7 commented Feb 19, 2026

LGTM, the tests are good 👍 I'd consider failing the check instead of showing a warning, since we want to enforce linking feature flags to Asana tasks.

Thanks! Reporting failure is the end goal, but I want to field-test it first for any false positives and not block work if I got it wrong.

@dus7 dus7 merged commit bed088d into main Feb 19, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants