Make rubocop happy

Author: loremattei

lib/fastlane/plugin/ddg_apple_automation/actions/start_new_release_action.rb

@@ -1,6 +1,7 @@
 require "fastlane/action"
 require "fastlane_core/configuration/config_item"
 require "octokit"
+require_relative "asana_add_comment_action"
 require_relative "../helper/asana_helper"
 require_relative "../helper/ddg_apple_automation_helper"
 require_relative "../helper/git_helper"
@@ -33,10 +34,12 @@ def self.run(params)
         options[:release_task_id] = release_task_id
 
         Helper::AsanaHelper.update_asana_tasks_for_internal_release(options) unless params[:is_hotfix]
-        Fastlane::Actions::AsanaAddCommentAction.run(
-          task_id: release_task_id,
-          comment: "TDS performance tests failed. Make sure to validate performance before releasing to public users."
-        ) if update_embedded_warning
+        if update_embedded_warning
+          Fastlane::Actions::AsanaAddCommentAction.run(
+            task_id: release_task_id,
+            comment: "TDS performance tests failed. Make sure to validate performance before releasing to public users."
+          )
+        end
       end
 
       def self.description

spec/ddg_apple_automation_helper_spec.rb

@@ -518,23 +518,23 @@ def load_file(file)
       expect(Fastlane::Actions).to have_received(:sh).with("git", "commit", "-m", "Update embedded files")
     end
 
-    it "returns true when TDS performance tests fail" do      
+    it "returns true when TDS performance tests fail" do
       allow(Fastlane::Actions).to receive(:sh).with("./scripts/update_embedded.sh").and_return("")
       git_status_output = "On branch main\nmodified: Core/trackerData.json\n"
       allow(Fastlane::Actions).to receive(:sh).with("git", "status").and_return(git_status_output)
       allow(Fastlane::Actions).to receive(:sh).with("git", "add", "Core/trackerData.json").and_return("")
       allow(Fastlane::Actions).to receive(:sh).with("git", "commit", "-m", "Update embedded files").and_return("")
       allow(other_action).to receive(:tds_perf_test).and_return(false)
       allow(other_action).to receive(:ensure_git_status_clean)
-      
+
       result = described_class.update_embedded_files(platform, other_action)
-      
+
       expect(result).to eq(true)
       expect(Fastlane::Actions).to have_received(:sh).with("git", "status")
       expect(Fastlane::Actions).to have_received(:sh).with("git", "add", "Core/trackerData.json")
       expect(Fastlane::Actions).to have_received(:sh).with("git", "commit", "-m", "Update embedded files")
     end
-    
+
     it "returns false when TDS performance tests pass" do
       allow(Fastlane::Actions).to receive(:sh).with("./scripts/update_embedded.sh").and_return("")
       git_status_output = "On branch main\nmodified: Core/trackerData.json\n"
@@ -545,7 +545,7 @@ def load_file(file)
       allow(other_action).to receive(:ensure_git_status_clean)
 
       result = described_class.update_embedded_files(platform, other_action)
-      
+
       expect(result).to eq(false)
       expect(Fastlane::Actions).to have_received(:sh).with("git", "status")
       expect(Fastlane::Actions).to have_received(:sh).with("git", "add", "Core/trackerData.json")

spec/start_new_release_action_spec.rb

@@ -91,7 +91,6 @@
           allow(Fastlane::Actions::AsanaAddCommentAction).to receive(:run)
         end
         it 'warns about TDS performance tests failures' do
-          
           subject
           expect(Fastlane::Actions::AsanaAddCommentAction).to have_received(:run).with(
             hash_including(