Merged
Conversation
ayoy
approved these changes
Mar 19, 2025
Contributor
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot @loremattei! I’ve run the action locally and it worked well 💪 I’ve left a bunch of minor comments, mostly related to naming. Please verify if ut_url values are correct for both iOS and macOS.
Contributor
Author
|
Thanks @ayoy ! |
Contributor
|
@loremattei yes, all looks great now, thanks! |
Contributor
Author
|
Thanks @ayoy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana Task: https://app.asana.com/0/1204165176092271/1209320018153084/f
This PR:
Adds a new TdsPerfTestAction action to run the TDS performance test. By default tests are run comparing the current embedded with the latest released one.
Runs this new Fastlane action before updating embedded TDS during code freeze and posts a comment on the release task if the test fails.
cc @bwaresiak