Skip to content

Add support for V0 Asana search URL #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayoy merged 2 commits into from
Apr 16, 2025
+6 −2
Merged

Add support for V0 Asana search URL #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63136b2
Add support for V0 Asana search URL
ayoy Apr 16, 2025
681793e
Bump version to 2.2.4
ayoy Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/fastlane/plugin/ddg_apple_automation/helper/asana_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class AsanaHelper # rubocop:disable Metrics/ClassLength
ASANA_TAG_URL_TEMPLATE = "https://app.asana.com/0/%s/list"

# https://app.asana.com/0/<project_id>/<task_id>
ASANA_V0_TASK_URL_REGEX = %r{https://app.asana.com/0/[0-9]+/([0-9]+)(?:/f)?}
ASANA_V0_TASK_URL_REGEX = %r{https://app.asana.com/0(?:/search)?/[0-9]+/([0-9]+)(?:/f)?}
# https://app.asana.com/<url_format_version>/<workspace_id>/<object_name>/<object_id>/<subobject_name>/<subobject_id>
ASANA_V1_TASK_URL_REGEX = %r{https://app.asana.com/1/[0-9]+(?:/[0-9a-z/]*)?/task/([0-9]+)(:?/[0-9a-z/]*)?(?:\?focus=true)?}
ASANA_V1_INBOX_URL_REGEX = %r{https://app.asana.com/1/[0-9]+/inbox/[0-9]+/item/([0-9]+)/story/([0-9]+)}
Expand Down
2 changes: 1 addition & 1 deletion lib/fastlane/plugin/ddg_apple_automation/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module Fastlane
module DdgAppleAutomation
VERSION = "2.2.3"
VERSION = "2.2.4"
end
end
4 changes: 4 additions & 0 deletions spec/asana_helper_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ def asana_task_url(task_id)
it "extracts task ID from a URL in focused mode" do
expect(extract_asana_task_id("https://app.asana.com/0/0/1234/f")).to eq("1234")
end

it "extracts task ID from search results" do
expect(extract_asana_task_id("https://app.asana.com/0/search/753241/9999")).to eq("9999")
end
end

context "v1 task URL" do
Expand Down