Skip to content

Fix this-release-includes for draft public releases#65

Merged
ayoy merged 3 commits intomainfrom
dominik/fix-this-release-includes
Mar 16, 2026
Merged

Fix this-release-includes for draft public releases#65
ayoy merged 3 commits intomainfrom
dominik/fix-this-release-includes

Conversation

@ayoy
Copy link
Copy Markdown
Contributor

@ayoy ayoy commented Mar 16, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201899738287924/task/1213684364815204

Description

When running a code freeze for version N+1 while version N's public release is still a draft, update_asana_tasks_for_internal_release would process tasks from the wrong version range.

Two issues fixed:

  • update_asana_tasks_for_internal_release now uses find_latest_public_release_tag (which handles draft releases) instead of latest_release (which ignored them and fell back to the N-1 tag).
  • find_latest_public_release_tag no longer fails when the latest internal release is for a newer version than the draft. It now uses find_latest_internal_release_for_version to search for the correct version-matching internal release.

Testing Steps

N/A

Impact and Risks

Low — only affects the tag lookup logic used when determining which Asana tasks to include in a release.

What could go wrong?

If no internal release is found for the draft's version, the workflow will fail with an error (same as before, but now only in genuinely broken scenarios).

Quality Considerations

N/A

Notes to Reviewer

N/A


Internal references:

Pull Request Review Checklist
Software Engineering Expectations


Note

Medium Risk
Changes GitHub release tag selection used to scope Asana task updates, including new paginated search for version-matching internal prereleases; mistakes could include wrong task ranges or failing the automation run if tags aren’t found.

Overview
Fixes internal-release Asana automation to derive the git-log start point from GitHelper.find_latest_public_release_tag (with an explicit error if no tag is found), preventing task collection from falling back to an older public tag when the latest public release is a draft.

Updates find_latest_public_release_tag to locate the version-matching internal prerelease via a new find_latest_internal_release_for_version paginated lookup, and adjusts specs accordingly. Bumps gem version to 4.0.1.

Written by Cursor Bugbot for commit 272696f. This will update automatically on new commits. Configure here.

ayoy added 3 commits March 16, 2026 11:29
…_release

When the latest public release is a draft (code freeze), the previous
logic skipped it and used the N-1 release tag, causing tasks from the
wrong version range to be included.
…ismatch

When the latest public release is a draft and a newer version's internal
releases already exist, find_latest_public_release_tag would fail because
the latest internal release didn't match the draft's version. Now it
searches for the correct version-matching internal release.
@kshann kshann self-requested a review March 16, 2026 11:18
@ayoy ayoy merged commit 606b17b into main Mar 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants