Fix this-release-includes for draft public releases#65
Merged
Conversation
…_release When the latest public release is a draft (code freeze), the previous logic skipped it and used the N-1 release tag, causing tasks from the wrong version range to be included.
…ismatch When the latest public release is a draft and a newer version's internal releases already exist, find_latest_public_release_tag would fail because the latest internal release didn't match the draft's version. Now it searches for the correct version-matching internal release.
kshann
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1201899738287924/task/1213684364815204
Description
When running a code freeze for version N+1 while version N's public release is still a draft,
update_asana_tasks_for_internal_releasewould process tasks from the wrong version range.Two issues fixed:
update_asana_tasks_for_internal_releasenow usesfind_latest_public_release_tag(which handles draft releases) instead oflatest_release(which ignored them and fell back to the N-1 tag).find_latest_public_release_tagno longer fails when the latest internal release is for a newer version than the draft. It now usesfind_latest_internal_release_for_versionto search for the correct version-matching internal release.Testing Steps
N/A
Impact and Risks
Low — only affects the tag lookup logic used when determining which Asana tasks to include in a release.
What could go wrong?
If no internal release is found for the draft's version, the workflow will fail with an error (same as before, but now only in genuinely broken scenarios).
Quality Considerations
N/A
Notes to Reviewer
N/A
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Note
Medium Risk
Changes GitHub release tag selection used to scope Asana task updates, including new paginated search for version-matching internal prereleases; mistakes could include wrong task ranges or failing the automation run if tags aren’t found.
Overview
Fixes internal-release Asana automation to derive the git-log start point from
GitHelper.find_latest_public_release_tag(with an explicit error if no tag is found), preventing task collection from falling back to an older public tag when the latest public release is a draft.Updates
find_latest_public_release_tagto locate the version-matching internal prerelease via a newfind_latest_internal_release_for_versionpaginated lookup, and adjusts specs accordingly. Bumps gem version to4.0.1.Written by Cursor Bugbot for commit 272696f. This will update automatically on new commits. Configure here.