[DO-NOT-MERGE] Pre-approved PR to disable MSP on Android if needed #2938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
CrisBarreiro
changed the base branch from
main
to
feature/cris/malicious-site-protection/start-rollout
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/stop-rollout
branch
2 times, most recently
from
8ef3eaa to
d62d495
Compare
Generated file outputs:Time updated: Tue, 06 May 2025 09:02:54 GMT legacytrackers-unprotected-temporary.txt (13 more)
v3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -299,9 +299,9 @@
"fireproofedWebLocalStorage": {
"state": "enabled"
},
"enableMaliciousSiteProtection": {
- "state": "enabled",
+ "state": "disabled",
"minSupportedVersion": 52301000
},
"httpError5xxPixel": {
"state": "enabled"
@@ -8075,9 +8075,9 @@
"exceptions": [],
"minSupportedVersion": 51670000
},
"maliciousSiteProtection": {
- "state": "enabled",
+ "state": "disabled",
"exceptions": [
{
"domain": "broken.third-party.site",
"reason": "A test page that helps us verify if exceptions work correctly."
@@ -8092,9 +8092,9 @@
"filterSetUpdateFrequency": 720
},
"features": {
"visibleAndOnByDefault": {
- "state": "enabled",
+ "state": "disabled",
"minSupportedVersion": 52301000,
"rollout": {
"steps": [
{
@@ -8107,8 +8107,11 @@
"percent": 50
}
]
}
+ },
+ "canUpdateDatasets": {
+ "state": "disabled"
}
}
},
"marketplaceAdPostback": {
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -290,9 +290,9 @@
"fireproofedWebLocalStorage": {
"state": "enabled"
},
"enableMaliciousSiteProtection": {
- "state": "enabled",
+ "state": "disabled",
"minSupportedVersion": 52301000
},
"httpError5xxPixel": {
"state": "enabled"
@@ -7534,9 +7534,9 @@
"exceptions": [],
"minSupportedVersion": 51670000
},
"maliciousSiteProtection": {
- "state": "enabled",
+ "state": "disabled",
"exceptions": [
{
"domain": "broken.third-party.site"
},
@@ -7549,9 +7549,9 @@
"filterSetUpdateFrequency": 720
},
"features": {
"visibleAndOnByDefault": {
- "state": "enabled",
+ "state": "disabled",
"minSupportedVersion": 52301000,
"rollout": {
"steps": [
{
@@ -7564,8 +7564,11 @@
"percent": 50
}
]
}
+ },
+ "canUpdateDatasets": {
+ "state": "disabled"
}
}
},
"marketplaceAdPostback": {
v4/extension-brave-config.json (12 more)
|
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/stop-rollout
branch
2 times, most recently
from
880edd3 to
e19d320
Compare
cmonfortep
previously approved these changes
Apr 7, 2025
Base automatically changed from
feature/cris/malicious-site-protection/start-rollout
to
main
April 7, 2025 08:21
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/stop-rollout
branch
from
9285ef0 to
4e19d22
Compare
CDRussell
approved these changes
May 5, 2025
CrisBarreiro
force-pushed
the
feature/cris/malicious-site-protection/stop-rollout
branch
from
4e19d22 to
d751d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1209879813659856/f
Description
Pre-approved PR to disable MSP on Android if needed
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled: maliciousSiteProtection
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference