Prevent feature automatic overriding going forward #2940
Conversation
|
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Wed, 21 May 2025 14:53:44 GMT legacytrackers-unprotected-temporary.txt (14 more)
latestv4/android-config.json (13 more)
|
|
I think we should just remove all features from this behavior with v5. I'll keep this open just in case we decide to adopt sooner. |
jonathanKingston
removed
the
DO NOT MERGE
| @@ -242,9 +304,6 @@ async function buildPlatforms() { | |||
| } | |||
|
|
|||
| platformConfig.features[key] = { ...platformOverride.features[key] }; | |||
| if (isFeatureMissingState(platformConfig.features[key])) { | |||
There was a problem hiding this comment.
iirc this gets caught with schema now.
If the feature doesn't have a "state" in the features file and also not in the platform. Also it'd be deleted above.
Asana Task/Github Issue: https://app.asana.com/0/1200890834746050/1209498509210908/f
Description
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference