Skip to content

Improve config-tests.js errors #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

jonathanKingston
Copy link
Collaborator

Asana Task/Github Issue:

Description

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

Copy link

github-actions bot commented May 8, 2025

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented May 8, 2025

Generated file outputs:

Time updated: Fri, 09 May 2025 00:26:02 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -13930,9 +13930,9 @@
                                 "percent": 20
                             }
                         ]
                     },
-                    "cohorts": [
+                    "cohort": [
                         {
                             "name": "control",
                             "weight": 0
                         },
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -12797,9 +12797,9 @@
                                 "percent": 20
                             }
                         ]
                     },
-                    "cohorts": [
+                    "cohort": [
                         {
                             "name": "control",
                             "weight": 0
                         },
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 8, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
github-actions bot pushed a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant