Skip to content

Mitigate cookie denial button breakage on forbes.com #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

laghee
Copy link
Contributor

@laghee laghee commented May 15, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/1206670747178362/task/1210261084351761?focus=true

Site breakage mitigation process:

Brief explanation

@laghee laghee requested a review from muodov May 15, 2025 13:36
@laghee laghee requested review from sammacbeth and a team as code owners May 15, 2025 13:36
@laghee laghee added the SBT-PFM Site breakage mitigation (Asana sync) label May 15, 2025
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Thu, 15 May 2025 13:37:50 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -221,8 +221,12 @@
                     "domain": "events.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/3172"
                 },
                 {
+                    "domain": "forbes.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/pull/3173"
+                },
+                {
                     "domain": "geo.fr",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2476"
                 },
                 {
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -206,8 +206,11 @@
                 {
                     "domain": "events.com"
                 },
                 {
+                    "domain": "forbes.com"
+                },
+                {
                     "domain": "geo.fr"
                 },
                 {
                     "domain": "ksta.de"

github-actions bot pushed a commit that referenced this pull request May 15, 2025
Base automatically changed from kate/mitigate-events-reload to main May 15, 2025 13:38
@@ -31,6 +31,14 @@
"domain": "eurostar.com",
"reason": "https://github.com/duckduckgo/privacy-configuration/issues/2229"
},
{
"domain": "events.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laghee was this intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SBT-PFM Site breakage mitigation (Asana sync)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants