Skip to content

Restart May25 test at 100% #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Restart May25 test at 100% #3209

merged 2 commits into from
May 22, 2025

Conversation

jdorweiler
Copy link
Collaborator

Asana Task/Github Issue:
https://app.asana.com/1/137249556945/project/11472677167855/task/1210057080197949

Description

Restarting may25 test at 100%

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

Site breakage mitigation process:

Brief explanation

  • Reported URL:
  • Problems experienced:
  • Platforms affected:
    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:
  • Feature being disabled/modified:
  • This change is a speculative mitigation to fix reported breakage.

@jdorweiler jdorweiler requested review from a team as code owners May 21, 2025 20:55
@jdorweiler jdorweiler requested a review from afterxleep May 21, 2025 20:55
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

@jdorweiler jdorweiler changed the title Jd/jun25 exp Restart May25 test at 100% May 21, 2025
Copy link

Generated file outputs:

Time updated: Wed, 21 May 2025 20:55:58 GMT

legacy
trackers-unprotected-temporary.txt (11 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -2068,30 +2068,30 @@
         "blockList": {
             "state": "enabled",
             "exceptions": [],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "minSupportedVersion": 52250000,
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/temp/android-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v5/temp/android-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-android-control.json",
+                        "treatmentUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-android-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }
v3/ios-config.json
--- v3/ios-config.json
+++ v3/ios-config.json
@@ -2039,29 +2039,29 @@
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2143"
                 }
             ],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/temp/ios-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v5/temp/ios-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-ios-control.json",
+                        "treatmentUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-ios-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }
v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -13337,29 +13337,29 @@
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2319"
                 }
             ],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v6/temp/macos-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v6/temp/macos-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v6/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-macos-control.json",
+                        "treatmentUrl": "v6/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-macos-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -1907,30 +1907,30 @@
         "blockList": {
             "state": "enabled",
             "exceptions": [],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "minSupportedVersion": 52250000,
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/temp/android-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v5/temp/android-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-android-control.json",
+                        "treatmentUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-android-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }
v4/extension-brave-config.json (10 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/ios-config.json
--- v4/ios-config.json
+++ v4/ios-config.json
@@ -1648,29 +1648,29 @@
                     "domain": "noaprints.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v5/temp/ios-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v5/temp/ios-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-ios-control.json",
+                        "treatmentUrl": "v5/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-ios-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }
v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -12942,29 +12942,29 @@
                     "domain": "wjla.com"
                 }
             ],
             "features": {
-                "tdsNextExperimentMay25": {
-                    "state": "disabled",
+                "tdsNextExperimentJun25": {
+                    "state": "enabled",
                     "rollout": {
                         "steps": [
                             {
-                                "percent": 25
+                                "percent": 100
                             }
                         ]
                     },
                     "settings": {
-                        "controlUrl": "v6/temp/macos-tdsnextexperimentmay25-tds-control.json",
-                        "treatmentUrl": "v6/temp/macos-tdsnextexperimentmay25-tds-treatment.json"
+                        "controlUrl": "v6/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-macos-control.json",
+                        "treatmentUrl": "v6/temp/tdsNextExperimentJune25/tdsNextExperimentJune25-macos-treatment.json"
                     },
                     "cohorts": [
                         {
                             "name": "control",
-                            "weight": 0
+                            "weight": 1
                         },
                         {
                             "name": "treatment",
-                            "weight": 0
+                            "weight": 1
                         }
                     ]
                 }
             }

@jdorweiler jdorweiler requested a review from GuiltyDolphin May 21, 2025 20:56
github-actions bot pushed a commit that referenced this pull request May 21, 2025
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdorweiler jdorweiler added this pull request to the merge queue May 22, 2025
Merged via the queue into main with commit 2ef777c May 22, 2025
23 checks passed
@jdorweiler jdorweiler deleted the jd/jun25-exp branch May 22, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants