Use JSONC for support of comments #4221
Conversation
|
👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.
👉 Please mark this as DRAFT unless there's an intention to merge this immediately. |
Generated file outputs:Time updated: Sat, 10 Jan 2026 10:38:49 GMT legacy29 files identical
latest14 files identical
|
JSON approval analysis:Time updated: Sat, 10 Jan 2026 10:38:54 GMT latest🎯 OVERALL APPROVAL STATUS✅ AUTO-APPROVED |
laghee
left a comment
laghee
left a comment
There was a problem hiding this comment.
LGTM if we add the error handling
Co-authored-by: Kate Manning <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ignores: [ | ||
| 'features/**/*.json', | ||
| 'overrides/**/*.json', | ||
| ], |
There was a problem hiding this comment.
ESLint config leaves autoconsent.json with no linting
Medium Severity
The ESLint configuration creates a linting gap for features/autoconsent.json. The JSONC config explicitly ignores this file (line 15), intending it to be linted as strict JSON. However, the strict JSON config (lines 20-23) ignores all features/**/*.json files. Since features/autoconsent.json matches this pattern, it's excluded from both configurations and receives no JSON linting at all. JSON syntax errors in this file would not be caught.
There was a problem hiding this comment.
It's already ignored in prettier anyway, intended.
2 participants
Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1212357634401271?focus=true
Description
Feature change process:
Site breakage mitigation process:
Brief explanation
Note
Enables JSONC (JSON with comments) across config sources and tooling.
readJsoncFileinutil.js(viajsonc-parser) and replace rawJSON.parseusages forlists/andoverrides/inindex.js,util.js, and testseslint.config.mjsto lintfeatures/**andoverrides/**witheslint-plugin-jsonc; keep strict JSON rules for other**/*.jsoneslint-plugin-jsoncandjsonc-parser; lockfile refreshedoverrides/windows-override.jsonWritten by Cursor Bugbot for commit bf20d64. This will update automatically on new commits. Configure here.